kernitus / BukkitOldCombatMechanics

Spigot plugin to configure combat mechanics from 1.9 onwards
https://www.spigotmc.org/resources/19510/
Mozilla Public License 2.0
168 stars 71 forks source link

Attack frequency on 1.10.0 #590

Closed KrusteF closed 1 year ago

KrusteF commented 2 years ago

https://prnt.sc/26j1s44

Problem Description

For the past 2 months I've been trying to fix a bug (thinking it's from my plugin), but today i noticed when i change the version to 1.9.0 (OCM) that this bugs gets fixed:

The attack frequency does not work properly on 1.10.0 (OCM), meaning the player / mob can hit the player 10+ times per second, video: https://youtu.be/kDEMSaP4HFs

You can clearly see that when the version is 1.10.0 the SLIME is attacking more then 1 or 2 times per second, but when the version is 1.9.0 he barely attacks

### To Reproduce Steps to reproduce the behavior: 1. Install 1.10.0 (OCM) version 2. Try getting attacked by a mob 3. Install 1.9.0 (OCM) version 4. Try getting attacked by a mob again ### Expected Behaviour As shown in the video, expected behaviour is to not being attacked 10+ times per second ### Actual Behaviour Every mob attacks more then once per second.
HamtaBot commented 2 years ago

oh sorry for the mention , i also have this bug

kernitus commented 1 year ago

@HamtaBot @KrusteF please try the new test builds, where I have rewritten most of the calculations that deal with damage.

kernitus commented 1 year ago

Closing due to rewrite of all damage calculation code. Please contribute debug logs to issue #636 if you think the problem is still present.