Fix random knockback - Githubissues

kernitus / BukkitOldCombatMechanics

Spigot plugin to configure combat mechanics from 1.9 onwards

https://www.spigotmc.org/resources/19510/

Mozilla Public License 2.0

168 stars 71 forks source link

Fix random knockback #592

Closed MWHunter closed 2 years ago

MWHunter commented 2 years ago

This is the hack I use on LegacyKB and it works fine. Unsure why bukkit doesn't call the velocity event after the damage event.

kernitus commented 2 years ago

Is this the same issue as #552 ?

MWHunter commented 2 years ago

No, this likely fixes https://github.com/kernitus/BukkitOldCombatMechanics/issues/569

kernitus commented 2 years ago

Commit caf99eb59e894ba6a143cbcbcf671203128476cb should do this without having to nuke the hashmap every tick, even if there is no damage event. Also I have no idea why you removed the AttackFrequency module there entirely, it has nothing to do with this PR.

MWHunter commented 2 years ago

I forgot about this PR so I used that branch like it wasn't attached to anything