Crazy unarmed damage

[klaidoshka]

Hello 👋 Because no one opened a ticket here regarding the newest version (or at least I can't see), I'm opening it...

The problem is that the unarmed attacks are totally ignoring armors, it's like people are shredding others with bare hands.

Not sure if this happens when something is being kept in the hand (sword/tool/w.e), but for sure it happens, when you are holding nothing. Just spam a bit and P6 full-netherite person will be dead in around 3 seconds. From bare hands.

Quite some people mentioned it in spigot reviews section, atm.

[klaidoshka]

old-potion-effects.strength.addend, disable it (enabled by default), fucks everything up. Great defaults. 😀

('fix' works only for armors, while having no armor, still ~16 damage is dealt <3)

Worth mentioning: this happens, when Strength 2 effect is up and you're doing around 10CPS.

Four hits: https://i.imgur.com/PAA4Nhk.png

[kernitus]

Thank you for opening a ticket, the spigot reviews are not the place for issue reporting. Could you clarify more what you're saying? What happens with armour and without armour? Does disabling the old-potion-effects module make a difference? Most importantly, what damage do you expect in those situations, and what do you get instead?

[klaidoshka]

Thank you for opening a ticket, the spigot reviews are not the place for issue reporting. Could you clarify more what you're saying? What happens with armour and without armour? Does disabling the old-potion-effects module make a difference? Most importantly, what damage do you expect in those situations, and what do you get instead?

This happens: (Lets say we have Player A and Player B (further - A, B))

A is fully armored, netherite materials, Prot4-10, whatever. B is unarmed, has nothing on himself, only Strength 2 effect. B hits A a few times with a speed of 8-10 clicks per second, A dies instantly, in less than 1.5 seconds. Why? B, for some reason, deals ridiculous damage with its second/third hit, while he should deal around 1-3 damage, not 15+.

Whether old-potion-effects disabling would fix everything, I am not sure, will try out and edit the message. But! Disabling this path: old-potion-effects.strength.addend fixes the ridiculous damage against armored people, but not against armorless people. Unarmed A player vs Unarmed B player with Strength 2 effect would lead to B player winning instantly anyways, but not if A player would have any armor (didn't test if 'ANY ARMOR' for real, just the ones with enchants)

edit: disabling entire old-potions-effects module fixes it, at least in my short tests.

[kernitus]

Alright thanks for the extra info, I will have to perform some tests on this to suss out where the issue actually lies. Also, all addend does is turn the strength modifier into +x instead of *x, because this was changed with 1.9.

[kernitus]

@klaidosHka please try the new test builds, where I have rewritten most of the calculations that deal with damage.

[kernitus]

Closing due to rewrite of all damage calculation code. Please open a new issue with debug logs from the latest version if you think the issue is still present.