kernitus / BukkitOldCombatMechanics

Spigot plugin to configure combat mechanics from 1.9 onwards
https://www.spigotmc.org/resources/19510/
Mozilla Public License 2.0
161 stars 69 forks source link

Wrong vertical knockback with CrackShot weapons #621

Open Fredh1000 opened 1 year ago

Fredh1000 commented 1 year ago

Information

Problem Description

Using crackshot weapons in the "modern" versions the vertical knockback of certain weapons will be "broken" and non-existent. I used Paper 1.16.5 for this test. P.S. This issue has been reported by other people in the past, but they did not provide complete descriptions and videos.

### To Reproduce Steps to reproduce the behavior: 1. Install Paper 1.16.5 with CrackShot and OCM 2. Start and add a weapon like this to weapons config in crackshot: https://pastebin.com/yzWanxLs 3. Reload weapons config with command /cra config reload 4. Give a player or mob 255 resistance (to keep him from dying instantly). 5. Hit him with the weapon (get it with command /shot get [weapon name]) and you'll see that vertical knockback will not be given. ### Expected Behaviour With the server in 1.8.8 vertical weapon knockback is okay. ### Actual Behaviour

the vertical knockback of certain weapons is non-existent.

Video Recordings

[Watch full video] Normal vertical KB with CrackShot 1.8.8 (normal 1.8.8 PvP) [Server version: Paper 1.8.8]: https://www.youtube.com/watch?v=cCBddfwBlsE [Watch full video] Bugged vertical KB with CrackShot 1.16.5 (old pvp with OCM) [Server version: Paper 1.16.5 + OCM]: https://www.youtube.com/watch?v=EJGG_QtqgQE

Additional information

The bullet of the test weapon I sent you is snawball, but it also behaves the same with arrows and in some cases also with projectiles energy. With the energy projectiles it seems to me that the absorption effect stops the knockback, if I remember correctly (I have not tested that of the energy, but if I remember correctly it was).

kernitus commented 1 year ago

Have you tried tweaking the values of the old knockback module, or disabling it completely? This is probably due to both plugins trying to modify the knockback at the same time

Fredh1000 commented 1 year ago

Yes, I tried but the knockback is always the same.