search

kernitus / BukkitOldCombatMechanics

Spigot plugin to configure combat mechanics for 1.9 onwards
https://www.spigotmc.org/resources/19510/
Mozilla Public License 2.0
179 stars 71 forks source link

A warn for a non NMS packet #632

Closed Hermelijn15 closed 1 year ago

Hermelijn15 commented 1 year ago

server version: paper 1.19.2 plugin version: 1.11.0 on a velocity network (maybe that is where the packet comes from?) [22:13:41 WARN]: [OldCombatMechanics] Received a packet that is not NMS: class io.netty.buffer.PooledUnsafeDirectByteBuf PooledUnsafeDirectByteBuf(ridx: 0, widx: 5, cap: 256) if i can provide more info please do let me know. this happens when a player joins the server

kernitus commented 1 year ago

It's entirely possible, is there more information printed at all? Do you have any plugins that might be modifying packets too?

Hermelijn15 commented 1 year ago

For packets on the server itself i dont think anything should mess with it, only thing i can think of is viaversion?

Hermelijn15 commented 1 year ago

also that is all it prints

kernitus commented 1 year ago

Hmm if you turn debug mode on in the config does it print anything more? It's definitely some other plugin directly writing packets

Hermelijn15 commented 1 year ago

image this is all that i see

Hermelijn15 commented 1 year ago

I do assume that it is not a big deal if it is caused by a different plugin?

I-Al-Istannen commented 1 year ago

That just means that OCM detected that some plugin is injecting arbitrary bytes into the player connection instead of server packets. OCM is not able to inspect and rewrite those (as they are no packets), so packet-based fixes like no-collision or sound/particle effect cancellations might no longer work correctly.

Chances are nothing will happen, but OCM might also no longer function properly. That depends on what plugin is injecting random bytes and for what reason.