search

kernitus / BukkitOldCombatMechanics

Spigot plugin to configure combat mechanics from 1.9 onwards
https://www.spigotmc.org/resources/19510/
Mozilla Public License 2.0
160 stars 70 forks source link

only set damage modifiers that are applicable #643

Closed rayzr522 closed 1 year ago

rayzr522 commented 1 year ago

closes #639

kernitus commented 1 year ago

When we get the DamageModifiers in first place, they are already filtered by isApplicable - filtering again before applying should not make any difference. The actual problem lies in the DefenceUtils class on line 133, where the absorption modifier is always added even if it was not in the original DamageModifiers set.

rayzr522 commented 1 year ago

gotcha, tysm :) clearly i didn't look closely enough! closing