search

kernitus / BukkitOldCombatMechanics

Spigot plugin to configure combat mechanics from 1.9 onwards
https://www.spigotmc.org/resources/19510/
Mozilla Public License 2.0
160 stars 70 forks source link

1.20 smithing table & netherite upgrade template #669

Closed Brottweiler closed 6 months ago

Brottweiler commented 1 year ago

Problem

Smithing table now requires a nether upgrade template. You cannot use only netherite ingot to upgrade diamond armour to netherite.

Proposed solution

There could be a setting to automatically provide a netherite upgrade template in the smithing table, similar how enchanting tables work with lapis, or how brewing stands work with blaze powder.

An issue might be that there are trim templates too. But maybe if you have a trim template, it can overwrite the netherite upgrade template.

kernitus commented 1 year ago

Interesting request, because netherite and smithing tables were not a thing in 1.8 and this is not directly combat related.

  1. What would be the main use-case for this?
  2. If somebody opened the smithing table and placed a diamond item and a netherite ingot, should the plugin automatically fill in the other slot with a non-removable Netherite Upgrade template? What if they want to use something else?
Brottweiler commented 1 year ago
  1. We use OldCombatMechanics for a special gamemode where players can enchant their stuff and make potions without also needing to get lapis and blaze powder, and with 1.20, we have a similar problem to solve since you need a netherite upgrade.
  2. Practically, it would automatically have a netherite upgrade in there, but if you put in a armour trim, it would replace it. Technically, I don't know if that is possible. Maybe it wouldn't be possible to replace the netherite upgrade with another item.

I realise this might be out of scope for this plugin, since it focuses on 1.8 pvp and not changing anything that was introduced after 1.8, so feel free to close this if you feel it is out of scope.

kernitus commented 10 months ago

We will keep this open for now but it is definitely low priority.

kernitus commented 6 months ago

It has been decided this is unfortunately out of scope for this plugin, which only deals with combat changes from 1.9 onwards.