search

kernkonzept / fiasco

The development version of the L4Re Microkernel
https://github.com/kernkonzept/fiasco/wiki
105 stars 23 forks source link

Make portable across different UNIX like #5

Closed sevenautumns closed 2 years ago

sevenautumns commented 2 years ago

Shebangs like
#!/usr/bin/perl and #!/usr/bin/sh
are not compatible with certain UNIX operating systems (like for example NixOS)

This PR aims to make building fiasco available to more UNIX like operating systems.

Relevant Article on !#/usr/bin/env

herrwiese commented 2 years ago

Hey Sven,

thanks for opening this PR and your input, I know this problem well. Unfortunately we cannot accept pull request through GitHub due to CLA stuff. I'll submit a slightly modified¹ change to our local code review system mentioning you as a contributor if that's okay with you. This will hopefully find its way to the GitHub release sooner than later.

I'll leave this open and report status until this happens.

¹⁾ /usr/bin/env sh actually isn't needed, as POSIX mandates /bin/sh being a POSIX shell and this actually is the other symlink besides /usr/bin/env that actually is guaranteed to exist on NixOS

sevenautumns commented 2 years ago

I'll submit a slightly modified¹ change to our local code review system

That is fine with me.

/usr/bin/env sh actually isn't needed, as POSIX mandates /bin/sh

I didnt notice this. My bad.

But Ive got another question regarding l4re.
My goal was that all packages in the l4re-snapshots follow this shebangs convention.
Who do I need to ask about this and is there a way for me to help?
Since you can not accept pull requests from Github, PRs might not be that helpful with this.
Should I just open an Issue in each Repository, addressing this?

herrwiese commented 2 years ago

I'm happy to tell you that the change successfully passed our review and QA and is already applied in our internal repo. I think it should become available with the next GitHub sync next week.

I'm currently fixing the shebangs in all our repos and those soon will also find the way here. Unfortunately, we are not directly responsible for l4re-snapshot, though. This is done independently from us at TU Dresden, who irregularly sync with us. So those changes should end up there, too, but I cannot tell you any resilient timeline.

sevenautumns commented 2 years ago

That sounds great!
Thank you for your update and help

sevenautumns commented 2 years ago

Thanks for your help.

de9a44c