kernvalley / whiskey-flat-days

Map and events app for Whiskey Flat Days
https://whiskeyflatdays.com
MIT License
0 stars 1 forks source link

Security and Accessibility issues (etc) #56

Open vanderbeam opened 4 years ago

vanderbeam commented 4 years ago

Describe the bug

To Reproduce

Expected behavior

shgysk8zer0 commented 4 years ago

Hi @vanderbeam and thanks for taking the time to report all of this.

Although this site will not be particularly relevant again for several months, these issues affect many kernvalley.us sites because it's components from my CDN.

I admit accessibility is something that is important, but has been somewhat difficult for me.

For the CSP, I've been seeing some of these as well, but haven't been able to do a thing about it.

Did you happen to catch where the disallowed requests are coming from? I have searched everything and those requests are not made anywhere.

I'm somewhat surprised to see someone else in the KRV who's familiar with things like CSP.
vanderbeam commented 4 years ago

@shgysk8zer0 The CSP error will show up in a variety of ways depending on which browser I'm using and if it has extensions activated or not, but will consistently report errors and warnings for:

I can't remember which page it was on and can't seem to recreate it, but there was a request loop that put the console errors close to 200 and continuously rising in Chrome. Depending on the page, I get anywhere from 10-20 in Incognito and Firefox (no extensions on either).

It seems like some of the iframes may be another root of some of these errors, too.

While admittedly I'm quite unfamiliar with hosting with GitHub and find it a curious choice, I know there have been some CSP issues in the past. Out of curiosity, since most venues in the area appear to be relatively small and it's not exactly California's next tech hub, how come GitHub/Jekyll is the direction you went in instead of something like WordPress or Square Space that would be easy for the client to manage? Again, no disrespect - you're the first person in the area I've potentially been able to talk shop with. It's been a long time since I've even logged into GitHub so at this point I couldn't imagine using it to host my client files.

Regarding the accessibility, it's my specialty. I've been in development for almost 15 years on and off but in the last few years, I've found a passion for using those skills to ensure universal access and am in the process of becoming a certified expert. I recently moved to the community last fall and have been hoping for an opportunity to use those skills to contribute. If you have ANY questions whatsoever or would appreciate an audit on the site, let me know and I would be more than happy to help. No, I'm not trying to sell my services to you, I'm offering them.

shgysk8zer0 commented 4 years ago

Quick answers to some questions here:

Other factors include the cell service/bandwidth issue in the area. I need sites to load reasonably quickly on even 3G and even with no service whatsoever (requires previous visit).

Go ahead and email admin@kernvalley.us and find a time to come by the Kernville Cowork sometime. There are a few devs here and it's a place to be familiar with.