search

keroro824 / HashingDeepLearning

Codebase for "SLIDE : In Defense of Smart Algorithms over Hardware Acceleration for Large-Scale Deep Learning Systems"
MIT License
1.07k stars 169 forks source link

CMake support #11

Closed sarthakpati closed 4 years ago

sarthakpati commented 4 years ago

Fixes issue #8

Adds all dependency build in the project, thereby not requiring any dependencies from the user other than CMake and a C++11 compliant compiler.

Needs testing on whatever platform this project was built last. ~I tried compiling on CentOS7 but failed [ref].~ Update: fixed with this include.

Looking forward to doing some amazing work with this!

Cheers, Sarthak

rahulunair commented 4 years ago

I can try building on Arch linux , Skylake i9 in sometime.

sarthakpati commented 4 years ago

Compiling on WSL:

root@pc:/mnt/c/Testing# lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 16.04.5 LTS
Release:        16.04
Codename:       xenial
[SNIP!]
root@pc:/mnt/c/Projects/HashingDeepLearning/bin_linux# ls -l
total 1344
-rwxrwxrwx 1 root root  13934 Mar  4 22:31 CMakeCache.txt
drwxrwxrwx 1 root root   4096 Mar  4 22:32 CMakeFiles
-rwxrwxrwx 1 root root   2673 Mar  4 22:31 cmake_install.cmake
drwxrwxrwx 1 root root   4096 Mar  4 22:26 CNPY-build
drwxrwxrwx 1 root root   4096 Mar  4 22:25 CNPY-prefix
drwxrwxrwx 1 root root   4096 Mar  4 22:26 CNPY-source
drwxrwxrwx 1 root root   4096 Mar  4 22:26 ep
-rwxrwxrwx 1 root root 750128 Mar  4 22:26 libSLIDE_LIB.a
-rwxrwxrwx 1 root root  16972 Mar  4 22:32 Makefile
-rwxrwxrwx 1 root root 579336 Mar  4 22:32 runme
drwxrwxrwx 1 root root   4096 Mar  4 22:26 ZLIB-build
drwxrwxrwx 1 root root   4096 Mar  4 22:25 ZLIB-prefix
drwxrwxrwx 1 root root   4096 Mar  4 22:26 ZLIB-source

The CMake port works!

rahulunair commented 4 years ago

May be rebase and update the PR?

sarthakpati commented 4 years ago

@rahulunair: Done!

sarthakpati commented 4 years ago

Hey @keroro824, could you give me an estimate on when this can be merged?

Cheers.

Tharun24 commented 4 years ago

Hey @sarthakpati , we trained with your changes but the code was super slow apparently bcz you didn't enable OpenMP. Can you fix that and push your commits?

sarthakpati commented 4 years ago

@Tharun24: done!

sarthakpati commented 4 years ago

Hello, any updates on the merge status?

Tharun24 commented 4 years ago

Hi Sarthak, really sorry for the delayed response. The new commit seems to throw segmentation fault. We are doing the following steps:

1) cmake CMakeLists.txt 2) make 3) make install . Then ./runme SLIDE/Config_file .

I'm I missing something? Can you please re-confirm that it works on your end?

Also, the MAPLEN value in Config.h file has to the output layer size in Config.csv file.

sarthakpati commented 4 years ago

Also, the MAPLEN value in Config.h file has to the output layer size in Config.csv file.

I didn't understand what you mean by this. I am not altering any source code..

keroro824 commented 4 years ago

@sarthakpati We are working on it :). What @Tharun24 was saying is some diagnosis details why we might fail on running the pull request. We will try to merge it by tonight!

keroro824 commented 4 years ago

@sarthakpati Thanks for a great job :)!