search

kerrickstaley / genanki

A Python 3 library for generating Anki decks
MIT License
1.99k stars 150 forks source link

Add multideck support and reorganize classes into files #20

Closed sciencemanx closed 5 years ago

sciencemanx commented 5 years ago

This makes the code easier to read and navigate through! Thanks.

sciencemanx commented 5 years ago

I'll fix these errors -- whats the best way to run the test locally tho?

sciencemanx commented 5 years ago

Apparently you can't stack PR's in Github so I'm lumping this all into one.

sciencemanx commented 5 years ago

@kerrickstaley Bump

kerrickstaley commented 5 years ago

@sciencemanx please split this into multiple PRs. I think there should be at least 3, one to fix the multideck issue, one to add the gitignore, and one to do the refactor. Ideally in that order.

If you want to get them reviewed in parallel, so that you have one PR which only shows the multideck change in the diff and another PR which only shows the refactor change in the diff, do this:

  1. Create a PR for the multideck issue.
  2. Create a new branch for the refactor, based off the multideck PR branch.
  3. When opening the PR for the refactor branch, choose the base branch to be your multideck PR branch, instead of kerrickstaley:master.
  4. Tag me in the refactor PR, because I think it will appear in your repo on GitHub and not in mine.
  5. Once I've reviewed both the multideck PR and the refactor PR, I'll commit them as two separate commits.

If you don't want to do that, just open the multideck and gitignore PRs, I'll review and commit them, then you can open the refactor PR.

sciencemanx commented 5 years ago

Sure I can do that -- however I think it will be easiest if we put the refactor and gitignore first, followed by the multideck support.

sciencemanx commented 5 years ago

@kerrickstaley See #22 and #23

waf commented 5 years ago

@sciencemanx thanks for working on this. I was able to use your branch https://github.com/sciencemanx/genanki/tree/multi-deck-support to successfully generate a multi-deck collection. You saved me a lot of time, thank you!

sciencemanx commented 5 years ago

@waf Glad I could help!