search

kerrickstaley / genanki

A Python 3 library for generating Anki decks
MIT License
1.99k stars 150 forks source link

Multi deck support #25

Closed sciencemanx closed 5 years ago

sciencemanx commented 5 years ago

This PR adds multideck support with the proposed solution from issue https://github.com/kerrickstaley/genanki/issues/18#issuecomment-443016527.

sciencemanx commented 5 years ago

Bump 😄

sciencemanx commented 5 years ago

@kerrickstaley -- Any chance you could review? The changes are actually pretty small -- shouldn't take too long.

marccarre commented 5 years ago

This is awesome! Thanks a lot! 🙂I really look forward to having this merged & released as I'm also facing #18. @sciencemanx, when do you think you will have a chance to address @kerrickstaley's comments?

kerrickstaley commented 5 years ago

I fixed this bug in https://github.com/kerrickstaley/genanki/commit/53bc7b4e1be3f19af022ef293faa0040bc5c35ee, and I've pushed the new version (0.6.4) to PyPI.

I ended up rewriting the patch because this PR refactors things in a way that doesn't match the existing code style, and which may make it harder to maintain the code long-term.

Sorry for the delay on fixing this, and thanks for your help!