search

kerrickstaley / genanki

A Python 3 library for generating Anki decks
MIT License
1.99k stars 150 forks source link

Multi deck support #26

Closed marccarre closed 5 years ago

marccarre commented 5 years ago

This PR adds multideck support with the proposed solution from issue https://github.com/kerrickstaley/genanki/issues/18#issuecomment-443016527.

It follows-up on and supersedes #25,

Disclaimer: apologies in advance to you @sciencemanx if you had plans to reply on/keep working on #25! 🙂I just need to create new Anki decks programmatically very soon, and issue #18 is currently a blocker.

Fixes #18. Closes #25.

marccarre commented 5 years ago

@kerrickstaley, if you're happy with this PR, would it be possible to create a new release of genanki once it is merged? 😊

marccarre commented 5 years ago

Anyone alive? 👋🙂

marccarre commented 5 years ago

In case anyone out there is interested in using this patch, I've just made it available via PyPi:

pip install genanki-marccarre==0.6.4

This is essentially this repository's master 6d173fcd8a50b29164d733fce750276bc9a9f39d version, with this PR on top of it, and a few smaller changes to be able to test and push to PyPi under a different package name. See also: https://github.com/kerrickstaley/genanki/compare/6d173fcd8a50b29164d733fce750276bc9a9f39d...marccarre:0.6.4 and my fork's sources for 0.6.4.

kerrickstaley commented 5 years ago

I fixed this bug in https://github.com/kerrickstaley/genanki/commit/53bc7b4e1be3f19af022ef293faa0040bc5c35ee, and I've pushed the new version (0.6.4) to PyPI.

I ended up rewriting the patch because this PR refactors things in a way that doesn't match the existing code style, and which may make it harder to maintain the code long-term.

Sorry for the delay on fixing this, and thanks for your help!