search

kerrickstaley / genanki

A Python 3 library for generating Anki decks
MIT License
2.06k stars 161 forks source link

Add mtherieau's Cloze code to genanki #37

Closed dvklopfenstein closed 5 years ago

dvklopfenstein commented 5 years ago

https://github.com/kerrickstaley/genanki/issues/3

Please consider this pull request which adds support for Cloze cards to genanki. I added the code from @mtherieau's gist example, as it works great.

Thank you creating this repo and sharing it with everyone and thank you for taking the time to consider this pull request.

dvklopfenstein commented 5 years ago

Thank you for considering the pull request and thank you for the useful suggestions. I will take a look in a little bit as I am under a deadline right now.

dvklopfenstein commented 5 years ago

Thank you for merging this. Is there anything else I need to do for completeness? Work sidelined me for a while.

Thank you for your code review and comments and adding to that last repeated field test. Your comments were constructive. If anything is else is needed for this PR, I have time to work on it tomorrow.

kerrickstaley commented 4 years ago

@dvklopfenstein sorry for the delay. I've published your changes to PyPI. Version 0.8.0 of genanki has your changes.