search

kerrickstaley / genanki

A Python 3 library for generating Anki decks
MIT License
1.99k stars 150 forks source link

Get pkg as bytes #53

Closed dallonasnes closed 3 years ago

dallonasnes commented 3 years ago

Added method to get package as bytes object. I used this to build a package on a server and send back to client for download. Includes unit test that verifies bytes package is still a valid anki package.

Also, two unit tests were failing when I had cloned the repo - both were from trying to unpack self.check_media() instead of accessing properties on the object. Those two are now fixed

dallonasnes commented 3 years ago

it seems my unit test fixes failed in travis, despite working on my machine. i'll revert them and submit a new pr