search

kerrickstaley / genanki

A Python 3 library for generating Anki decks
MIT License
2.06k stars 161 forks source link

Update model.py #70

Closed Damien-75 closed 3 years ago

Damien-75 commented 3 years ago

Added "from .. " to the import of local modules/packages to avoid conflict with other homonyms used by other Anki add-ons, eventually leading to run time errors. (I.E. "Chinese Support Redux" - https://ankiweb.net/shared/info/1128979221 - also using pystache and yaml)

These 4 pull requests need to be coordinated: Chinese-Prestudy: Update init.py Chinese-Vocab-List: Update init.py chineseflashcards : Update init.py genanki: Update model.py

Damien-75 commented 3 years ago

Although these modifications work on my setup, they didn't get through the automatic checks.

There are some cleaner solutions like the ones documented here: https://chrisyeh96.github.io/2017/08/08/definitive-guide-python-imports.html#case-2-syspath-could-change The workaround n°2 doesn't work on my setup the workaround n°3 is working, though