black-puppydog commented 3 years ago

pystache has been unmaintained for a long time, with the [last commit] to defunkt/pystache being from September 2014. By now it is not installable with up-to-date setuptools. Luckily, genanki uses only the most basic of mustache API, and chevron fills the gap nicely. Tests are passing for me again.

[last commit]: https://github.com/defunkt/pystache/commit/17a5dfdcd56eb76af731d141de395a7632a905b8

f-koehler commented 3 years ago

I just tested this, works fine and the changes look trivial enough. Hopefully @kerrickstaley will merge this soon. I believe this is the way to go.

codecov-commenter commented 3 years ago

Codecov Report

Merging #93 (f8ee5ee) into master (10a356b) will decrease coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
- Coverage   95.29%   95.28%   -0.02%     
==========================================
  Files          11       11              
  Lines         319      318       -1     
==========================================
- Hits          304      303       -1     
  Misses         15       15

Impacted Files	Coverage Δ
genanki/card.py	`100.00% <100.00%> (ø)`
genanki/model.py	`93.33% <100.00%> (-0.18%)`	:arrow_down:
genanki/note.py	`97.41% <100.00%> (+0.02%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 73d3cbf...f8ee5ee. Read the comment docs.

kerrickstaley commented 3 years ago

Thanks for the PR!

kerrickstaley / genanki

Replace pystache with chevron #93

Codecov Report