kerrj / lerf

Code for LERF: Language Embedded Radiance Fields
https://www.lerf.io/
MIT License
668 stars 65 forks source link

add missing argument grad_scaler for LERFPipeline #32

Closed sangminkim-99 closed 1 year ago

sangminkim-99 commented 1 year ago

Hi, @kerrj! Thank you for sharing this great work!

I noticed that with the recent update to nerf-studio, there have been some changes made to the arguments in the VanillaPipeline. (nerfstudio-project/nerfstudio@a8bce87ada9124bf5f2e0b73d5d918f8cf9f1c35) Unfortunately, this modification has led to an error stating TypeError: init() got an unexpected keyword argument 'grad_scaler'. To resolve this issue, I manually added the 'grad_scaler' argument to the LERFPipeline.

Once again, thank you for your valuable work and for considering my suggestion.