search

kersing / multitech-installer

Installer for TheThingsNetwork on MultiTech Conduit
MIT License
21 stars 17 forks source link

mp_pkt_fwd fails to exit on stop #19

Open Eelviny opened 5 years ago

Eelviny commented 5 years ago

When executing /etc/init.d/ttn-pkt-forwarder stop, the process /opt/lora/mp_pkt_fwd usually does not also get stopped.

This breaks functionality with packages like monit, which attempt to restart the service when an issue is detected. Instead, a duplicate process is spawned, and the problem continues.

I fixed this issue by modifying the /etc/init.d/ttn-pkt-forwarder file, so that do_stop() does killall mp_pkt_fwd. The original behaviour is killall -1 mp_pkt_fwd. This is a "quick fix" but the issue lies in mp_pkt_fwd refusing to exit cleanly.

Eelviny commented 5 years ago

This is on an MTCAP-LEU1-868 running mLinux 4.0.1.

Eelviny commented 5 years ago

I might be wrong about this - more info on how this actually works is appreciated

kersing commented 5 years ago

To fix this, replace the '-s 1' with '-s 3' and 'killall -1' with 'killall -3' in /etc/init.d/ttn-pkt-forwarder