search

kersing / packet_forwarder

Multi protocol packet forwarder supporting the TTN gateway-connector protocol.
Other
86 stars 56 forks source link

gps coordinate update mutex #4

Closed grahamehorner closed 7 years ago

grahamehorner commented 7 years ago

mutex lock should protect the return state held by i

kersing commented 7 years ago

Thank you for the update, however the files in that directory are not used for the multi protocol forwarder and are maintained by upstream. For that reason I will not apply the patch. You might want to provide https://github.com/Lora-net/lora_gateway with the update (if still required)

kersing commented 7 years ago

My applogies, upstream should be https://github.com/Lora-net/lora_gateway

grahamehorner commented 7 years ago

I've checked the repo link provided and can't find the directory or files for this? unsure if the repo has been update since you cloned the upstream or if the provide is incorrect?

grahamehorner commented 7 years ago

note the same issue is present in the mp_pkt

            / update gateway coordinates /             i = lgw_gps_get(NULL, NULL, &coord, &gpserr);             pthread_mutex_lock(&mx_meas_gps);             if (i == LGW_GPS_SUCCESS) {                 gps_coord_valid = true;                 meas_gps_coord = coord;                 meas_gps_err = gpserr;                 // TODO: report other GPS statistics (typ. signal quality & integrity)             } else {                 gps_coord_valid = false;             }