search

kerubistan / kerub

A lightweight IaaS prototype
Apache License 2.0
13 stars 4 forks source link

redundant data in host hostory records #262

Closed K0zka closed 4 years ago

K0zka commented 4 years ago

storageStatusById is for example absolutely not needed. Maybe if something is anyway annotated with @JsonIgnore, then the history records could ignore them

    @get:JsonIgnore
    val storageStatusById by lazy {
        storageStatus.associateBy { it.id }
    }
{
  "id" : "e30b44be-1a57-4747-8ee7-ca49a0494275",
  "entityKey" : "42367968-d06f-45ef-aff8-709d9c73711a",
  "time" : 1569649972325,
  "appVersion" : "0.2.0-SNAPSHOT",
  "changes" : [ {
    "property" : "lastUpdated",
    "oldValue" : 1569649971666,
    "newValue" : 1569649972325
  }, {
    "property" : "storageStatus",
    "oldValue" : [ {
      "id" : "11ee2350-36be-4112-93f0-b5ee15f4fc3a",
      "reportedFreeCapacity" : 801112064,
      "items" : [ {
        "name" : "/dev/vda2",
        "freeCapacity" : 801112064
      } ],
      "pools" : [ {
        "name" : "pool00",
        "size" : 4030726144,
        "freeSize" : 1738049113
      } ],
      "freeCapacity" : 801112064
    }, {
      "id" : "985541c6-af92-4ce3-8650-ef2fe2da3c3a",
      "freeCapacity" : 2303524864
    }, {
      "id" : "461e2d4f-91e7-4eba-9414-640e103e0e1f",
      "freeCapacity" : 235085824
    } ],
    "newValue" : [ {
      "id" : "11ee2350-36be-4112-93f0-b5ee15f4fc3a",
      "reportedFreeCapacity" : 801112064,
      "items" : [ {
        "name" : "/dev/vda2",
        "freeCapacity" : 801112064
      } ],
      "pools" : [ {
        "name" : "pool00",
        "size" : 4030726144,
        "freeSize" : 1738049113
      } ],
      "freeCapacity" : 801112064
    }, {
      "id" : "985541c6-af92-4ce3-8650-ef2fe2da3c3a",
      "freeCapacity" : 2303643648
    }, {
      "id" : "461e2d4f-91e7-4eba-9414-640e103e0e1f",
      "freeCapacity" : 235085824
    } ]
  }, {
    "property" : "storageStatusById",
    "oldValue" : {
      "11ee2350-36be-4112-93f0-b5ee15f4fc3a" : {
        "id" : "11ee2350-36be-4112-93f0-b5ee15f4fc3a",
        "reportedFreeCapacity" : 801112064,
        "items" : [ {
          "name" : "/dev/vda2",
          "freeCapacity" : 801112064
        } ],
        "pools" : [ {
          "name" : "pool00",
          "size" : 4030726144,
          "freeSize" : 1738049113
        } ],
        "freeCapacity" : 801112064
      },
      "985541c6-af92-4ce3-8650-ef2fe2da3c3a" : {
        "id" : "985541c6-af92-4ce3-8650-ef2fe2da3c3a",
        "freeCapacity" : 2303524864
      },
      "461e2d4f-91e7-4eba-9414-640e103e0e1f" : {
        "id" : "461e2d4f-91e7-4eba-9414-640e103e0e1f",
        "freeCapacity" : 235085824
      }
    },
    "newValue" : {
      "11ee2350-36be-4112-93f0-b5ee15f4fc3a" : {
        "id" : "11ee2350-36be-4112-93f0-b5ee15f4fc3a",
        "reportedFreeCapacity" : 801112064,
        "items" : [ {
          "name" : "/dev/vda2",
          "freeCapacity" : 801112064
        } ],
        "pools" : [ {
          "name" : "pool00",
          "size" : 4030726144,
          "freeSize" : 1738049113
        } ],
        "freeCapacity" : 801112064
      },
      "985541c6-af92-4ce3-8650-ef2fe2da3c3a" : {
        "id" : "985541c6-af92-4ce3-8650-ef2fe2da3c3a",
        "freeCapacity" : 2303643648
      },
      "461e2d4f-91e7-4eba-9414-640e103e0e1f" : {
        "id" : "461e2d4f-91e7-4eba-9414-640e103e0e1f",
        "freeCapacity" : 235085824
      }
    }
  } ]
}