kerudion / chunksfadein

A simple mod that adds bedrock-like chunk fade-in animation
GNU General Public License v3.0
50 stars 6 forks source link

[FEATURE]: Distant Horizons Support #80

Open BetaKors opened 2 months ago

BetaKors commented 2 months ago

Before creating a request, please make sure you have checked the following:

What has to be improved/added?

Currently, whenever the player moves through the world, newly loaded chunks at the boundary between real chunks and DH chunks get faded in, instead of just the game just seamlessly exchanging DH chunks for real chunks with no transition. Here's a video that shows what's happening:

https://github.com/kerudion/chunksfadein/assets/88991219/525ff987-4f23-4bd1-a07f-bb12dbe389d8

My suggestion is to check if a real chunk has a corresponding DH chunk or is surrounded by DH chunks, and, if it is, don't fade it in.

peow commented 1 month ago

I think the Chunks Fade In mod could really fix a problem with Distant Horizons. DH kind of breaks the immersion because the LOD chunks suddenly pop into real chunks without any fade. Chunks Fade In could totally fix this by making the real chunks fade in over the LOD chunks. Right now, the LODs just disappear and the real chunks start showing up bit by bit, which makes the void color show up during the transition.

https://github.com/kerudion/chunksfadein/assets/105888751/f7d6bfb6-0d40-4f6d-9af9-5df65491d000


Check out how it looks right now using just DH:

https://github.com/kerudion/chunksfadein/assets/105888751/4621ac60-97d8-493c-a328-4d458a5aa799