search

kervinck / gigatron-rom

System, apps and tooling for the Gigatron TTL microcomputer
BSD 2-Clause "Simplified" License
231 stars 80 forks source link

Security issue Contrib/PhilThomas/package-lock.json ("minimist") #163

Closed kervinck closed 4 years ago

kervinck commented 4 years ago

I have another warning from Github about the Gigatron repo:

image

@PhilThomas: Would you mind to take a look?

It would be worthwhile to find out how we can avoid getting these security issues affecting the Gigatron repository. I fear one day GitHub might lock us out because of these things. Any suggestions are welcome.

PhilThomas commented 4 years ago

I'm on it.

Phil

On Sun, Mar 15, 2020, 1:30 AM Marcel van Kervinck notifications@github.com wrote:

I have another warning from Github about the Gigatron repo:

[image: image] https://user-images.githubusercontent.com/12294510/76698015-377c9980-669e-11ea-8b3a-4676e1667d7b.png

@PhilThomas https://github.com/PhilThomas: Would you mind to take a look?

It would be worthwhile to find out how we can avoid getting these security issues affecting the Gigatron repository. I fear one day GitHub might lock us out because of these things. Any suggestions are welcome.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kervinck/gigatron-rom/issues/163, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANHIDLQUTVED2L7H7AGJLTRHSGZ7ANCNFSM4LKVLFJA .

kervinck commented 4 years ago

The security banner disappeared after merging https://github.com/kervinck/gigatron-rom/pull/164 Thanks for the super fast response. These things are nerve wrecking to me.

PhilThomas commented 4 years ago

No problem. It was a dev dependency, not a deployment dependency, but there are no longer any dependencies of either kind, so this should not happen again.

Cheers

Phil

On Sun, Mar 15, 2020, 3:37 PM Marcel van Kervinck notifications@github.com wrote:

The security banner disappear after merging #164 https://github.com/kervinck/gigatron-rom/pull/164 Thanks for the super fast response. These things are nerve wrecking to me.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kervinck/gigatron-rom/issues/163#issuecomment-599274436, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANHIDJDAHMGDRBT7MIEQA3RHVKDTANCNFSM4LKVLFJA .