kervinck / gigatron-rom

System, apps and tooling for the Gigatron TTL microcomputer
BSD 2-Clause "Simplified" License
229 stars 79 forks source link

Pull request (GLCC update) #248

Closed lb3361 closed 1 year ago

lb3361 commented 1 year ago

This is a combined pull-request that could be split as needed.

All three items can be discussed independently to best satisfy the wishes of our community. I'll update the pull request accordingly.

at67 commented 1 year ago

Pull request won't be accepted as per https://forum.gigatron.io/viewtopic.php?t=19, I don't have the hours required to review the amount of changes you have made to the root/core.

The simple solution is to refactor it all so that it sits in your Contrib area, as everyone else, (including myself has done), see the above forum thread.

lb3361 commented 1 year ago

I propose to reshuffle the commit as follows:

  1. Move GLCC under Contrib/lb3361 and update it there.

  2. Keep the ROMv6 changes into the main directories, because (a) it is a small change in terms of code, (b) it is a fair approximation of what we know Marcel had in mind, and (c) because there is value in providing a stable development target to app developers, with properly versioned syscalls and interface.json. This would improve the life expectancy of the official gigatron rom, which I see as a benefit our community

  3. Move all Dev7 developments under Contrib/lb3361.

lb3361 commented 1 year ago

This pull request has been reduced to only contain the GLCC update (one commit, entirely inside Compilers/glcc). The other changes will be turned into separate pull requests, each with proper argumentation.