Closed lb3361 closed 1 year ago
Pull request won't be accepted as per https://forum.gigatron.io/viewtopic.php?t=19, I don't have the hours required to review the amount of changes you have made to the root/core.
The simple solution is to refactor it all so that it sits in your Contrib area, as everyone else, (including myself has done), see the above forum thread.
I propose to reshuffle the commit as follows:
Move GLCC under Contrib/lb3361 and update it there.
Keep the ROMv6 changes into the main directories, because (a) it is a small change in terms of code, (b) it is a fair approximation of what we know Marcel had in mind, and (c) because there is value in providing a stable development target to app developers, with properly versioned syscalls and interface.json. This would improve the life expectancy of the official gigatron rom, which I see as a benefit our community
Move all Dev7 developments under Contrib/lb3361.
This pull request has been reduced to only contain the GLCC update (one commit, entirely inside Compilers/glcc). The other changes will be turned into separate pull requests, each with proper argumentation.
This is a combined pull-request that could be split as needed.
The first commit upgrades GLCC to the latest version
The next seven commits (up to 78f3021) are a ROMv6 release. The native code itself is essentially dev rom, that is, an approximation of what ROMv5 could have been (bugs fixed plus good support for expansion cards). The application selection removes pictures and tetronis, adds invaders (pristine) and gamine. New credits application gives proper credits for tall this. At this point the dev rom is the same as ROMv6 save for romTypeValue.
The last tree commits upgrade the dev rom to dev7, without changing the application selection other than a slightly faster Mandelbrot (found another 25%) and having a version of MSCP in Apps (but not included in the ROM)
All three items can be discussed independently to best satisfy the wishes of our community. I'll update the pull request accordingly.