kervinck / gigatron-rom

System, apps and tooling for the Gigatron TTL microcomputer
BSD 2-Clause "Simplified" License
229 stars 79 forks source link

Pull request v6 #249

Closed lb3361 closed 1 year ago

lb3361 commented 1 year ago

This is a pull request for ROMv6 which will be updated in light of the comments and concerns that will arise.

The native code of ROMv6 is 99.9% identical to current dev rom (one exception documented below) which has already been extensively tested. Compared to ROMv5a, it brings some bug fixes, a few useful system calls, and a far more usable support for all kinds of ram & io expansion boards like the one Marcel was developing. Many of the application changes were already present in the dev rom (faster Mandelbrot, workable card boot, racer improvements). This pull request proposes to change the application selection by replacing "Pictures" and "Tetronis" by at67's "Invader" and hans61's "gtmine". This can of course be changed. My reasons for choosing this two programs was that (a) Invader is widely recognized as a tour-de-force that illustrates what can be done within the boundaries of the classic ROMs, and (b) GtMine is a version of the classic minesweeper that one finds in virtually all operating systems, so why not the Gigatron rom.

The pull request is made of seven commits described in detail below:

at67 commented 1 year ago

1) gtemuAT67 pull request is in the wrong repo, I have already added the changes to the correct repo. 2) As previously stated Invader is not available for any other ROM's except ROMvX0, no at67 applications are available for any ROM's other than ROMvX0.

Fix 1) and 2) by removing them from the pull request and I will accept the pull request.

lb3361 commented 1 year ago

Ok. I will prepare an updated pull request.

Regarding (1), to which repo should we submit pull requests regarding gtemuat67?

Regarding (2), I had hoped that you would consider the mainline rom differently. I will not discuss your decision but ask for community suggestions to find a good replacement, using as open as possible a process.

at67 commented 1 year ago

1) https://github.com/at67/gigatron-rom/tree/master/Contrib/at67

2) Sounds like a good idea, there's a large pool of appropriate candidates.

lb3361 commented 1 year ago

The pull request has been updated and should be ready to go now

Here is a breakthrough of all the commits: