search

kervyntan / pe

0 stars 0 forks source link

Phone number restriction on 8xxx, 9xxx a little too restrictive #9

Open kervyntan opened 7 months ago

kervyntan commented 7 months ago

Screenshot 2024-04-19 at 4.59.38 PM.png

Description

Consider clients' who still prefer sticking to receiving a call over the landline rather than through a mobile phone/smartphone, there won't be an option available to save these clients' contact numbers.

Steps to reproduce

  1. Launch the application for the first time to load initial data.

  2. Run add n/Bobby Tay p/6789 2646 e/BobbyTay@gmail.com a/Blk 123 Foo Street 45, #07-89 t/PRUactiveCash.

Suggested behaviour

Be able to add contacts who have landline numbers beginning with 6xxx

Actual behaviour

Contact is not able to be added successfully

soc-pe-bot commented 6 months ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

Thank you for the bug report.

FINDvisor is built with the fact that duplicate contacts are based on mobile phone numbers and is part of the scope of our application.

image.png

In the case of a landline number, multiple people can use the same landline which would make it difficult to identify.

We do agree that there can be clients who prefer to be contacted over landline. However, we decided that this feature is not in scope as we have other fields such as remark which allow users to indicate that these clients prefer to be contacted by landline and include the landline number as well, rather than dedicating a specific field or tweaking our current phone number field to accommodate for landline numbers.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your reason]