search

keryja / factorio-fast-filter-fill

A Factorio mod for quickly setting cargo wagon filters (Original by SeaRyanC, Continued by Keryja)
https://mods.factorio.com/mods/Keryja/fast-filter-fill
MIT License
1 stars 1 forks source link

On gui opened bug #6

Closed Jelmergu closed 6 years ago

Jelmergu commented 6 years ago

I don't know exactly what we did, but during a multiplayer game an error. I have attached an image of the error and the savegame itself to the report report error on_gui_opened error_on_gui_opened.zip

keryja commented 6 years ago

The error occurs when something is opened, what did you open at the time? It would help with testing a fix. Thanks!

Jelmergu commented 6 years ago

I opened my characters inventory. What my multiplayer partner opened I don't know I am prepared to try it out with you in the same multiplayer server if you'd want.

keryja commented 6 years ago

I've uploaded a new version of the mod that should fix things, let me know if you still have issues.

Jelmergu commented 6 years ago

Will do

keryja commented 6 years ago

We were checking for the get_output_inventory() method on player.opened, unfortunately Factorio's table class throws an error when accessing a key that doesn't exist. Instead of that we now check if player.opened is a LuaEntity which will always have the get_output_inventory() method.

Jelmergu commented 6 years ago

Yeah, that error throwing is a problem I am familiar with...

keryja commented 6 years ago

Considering this fixed