search

kerzol / papers

Papersᵞ — Discussion board for scientific papers
http://papers-gamma.link
16 stars 4 forks source link

Improving the search in the catalog page #15

Closed josephabirached closed 3 years ago

josephabirached commented 3 years ago

I made the changes requested!

I also added a verification to check if the string is white-space before querying the database in the if statement (line 142).

josephabirached commented 3 years ago

There is no particular reason I used UNION ALL instead of UNION. If we were to use UNION we can remove the DISTINCT in the primary select statement.

Which one do you think is better?

kerzol commented 3 years ago

The two approaches will give the same result. I do not know which one is faster :) So, let's leave it as it is, with 'DISTINCT'.

kerzol commented 3 years ago

merged!

On 25/10/2021, josephabirached @.***> wrote:

There is no particular reason I used UNION ALL instead of UNION. If we were to use UNION we can remove the DISTINCT in the primary select statement.

Which one do you think is better?

-- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/kerzol/papers/pull/15#issuecomment-951109119