search

keshav-space / safenotes

Safe Notes is a security project aimed at providing an encrypted, private note manager that works locally and protects notes from various threat actors.
https://safenotes.dev
GNU General Public License v3.0
227 stars 22 forks source link

Enable and then disable Biometric #134

Closed debasen closed 6 months ago

debasen commented 1 year ago

Is your feature request related to a problem? Please describe. I understand the problem of enabling biometric. But if it is enabled and then disabled later is it still a threat? I mean will my passphrase still be saved in the app? Or I will be good as fresh installation?

Describe the solution you'd like A clear and concise description of what you want to happen.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

keshav-space commented 1 year ago

I understand the problem of enabling biometric. But if it is enabled and then disabled later is it still a threat? I mean will my passphrase still be saved in the app? Or I will be good as fresh installation?

As soon as you disable biometric authentication, the passphrase gets purged from storage.

https://github.com/keshav-space/safenotes/blob/9f938b18ad6b5c0094c63b7f35e1b749dae11298/lib/models/biometric_auth.dart#L21-L29

debasen commented 1 year ago

Oh, great! Any reason to first override the value and then delete it?

keshav-space commented 1 year ago

Oh, great! Any reason to first override the value and then delete it?

That's an additional safeguard measure. It never hurts to be more cautious.

keshav-space commented 6 months ago

@debasen closing this now. Hope you got your answer. From next time, if you have any queries, please open a Q&A discussion here https://github.com/keshav-space/safenotes/discussions/new?category=q-a