Add support for secure compilation flags on aarch64 (specific) and generic

keshavbhatt / whatsie

Feature rich WhatsApp Client for Desktop Linux

MIT License

1.98k stars 59 forks source link

Add support for secure compilation flags on aarch64 (specific) and generic #188

Closed looptc closed 1 month ago

looptc commented 3 months ago

Hi,

I would like to have those secure flags by default on the main repo because they improve the security of the binary procuded by the compilation process.

This pull request only gives support to ROP protection with the -mbranch-protection flag on aarch64, but specifying -fcf-protection can enable it for x86_64.

I don't know how to make a platform dependant compilation flags switching, but maybe you encounter this pull request interesting and know how to do it well.

Best regards.

keshavbhatt commented 1 month ago

@looptc Thanks for the PR, I approached the same based on your suggestions in https://github.com/keshavbhatt/whatsie/commit/4720ffebebcb7e81c7f6e4f193a5732e5bee73ca let me know if it is enough.

looptc commented 1 month ago

Looks awesome! Thank you.