Add Reolink NVR camera support

keshavdv / unifi-cam-proxy

Enable non-Ubiquiti cameras to work with Unifi NVR

MIT License

1.72k stars 236 forks source link

Add Reolink NVR camera support #19

Closed JakeShirley closed 3 years ago

JakeShirley commented 3 years ago

Added support for Reolink NVR cameras for motion events
- I did not test this with standalone Reolink cameras. Similar code would likely work but this uses channel IDs and what not, so it wouldn't work out of the box.
Fixed a crash when trying to log the lack of FFMPEG

~Note: Still testing the video streaming because my Windows environment with FFMPEG was wonky~ Tested with WSL, the changes seem to work!

JakeShirley commented 3 years ago

@keshavdv I'd love your thoughts on this! Thanks for this whole project, it makes the slow transition to Unifi Protect easier!

JakeShirley commented 3 years ago

Side note: I don't know docker super well but it looks like this docker image just pip installs the public facing package. It'd be nice if it could package the files locally instead so it'd be easy to package and deploy local changes.

Alestrix commented 3 years ago

Side note: I don't know docker super well but it looks like this docker image just pip installs the public facing package. It'd be nice if it could package the files locally instead so it'd be easy to package and deploy local changes.

You have the same misunderstanding about docker that I used to have, i.e. mixing up build time and runtime. I asked the same question on reddit once: https://www.reddit.com/r/docker/comments/lt4esv/why_do_many_docker_images_install_their_content/

JakeShirley commented 3 years ago

@Alestrix that makes sense, but doesn't this line (in docker/Dockerfile which is at build time) install the latest pip package, or is it somehow using the files in the repo next to the Dockerfile:

RUN pip install unifi-cam-proxy

Alestrix commented 3 years ago

@Alestrix that makes sense, but doesn't this line (in docker/Dockerfile which is at build time) install the latest pip package, or is it somehow using the files in the repo next to the Dockerfile:
RUN pip install unifi-cam-proxy

Oops, you are right. It doesn't use a freshly built unifi-cam-proxy, but whatever is latest using pip. Since the pip install is done within a standard Dockerhub python container, I do not expect it to be using any special local repositories.

JakeShirley commented 3 years ago

@keshavdv One last thing I guess I should add/make sure exists is a way to invoke custom cameras from Docker. Any thoughts on this?