Closed bdsoha closed 1 year ago
@bdsoha can you please resolve the conflicts in this pr? Not that I can merge it but should get the ball rolling.
@keshavdv the repo is failing to build and this person is attempting to fix it. When you have a moment can you please review? For now the docker container in dockerhub remains broken.
@bdsoha i do not think this will fully fix the issues. i forked your repo and have begun fixing the build issues but I am not sure how to handle the one that cargo is now throwing. you can see my changes here. https://github.com/Syco54645/unifi-cam-proxy/tree/newmaster
@Syco54645 You are still working off of the main
branch (which does not include my changes).
Make sure to fork the correct branch (bdsoha:feature/combine-setup
).
@bdsoha my bad, I thought I had. I will do that next time I feel ambitious.
@keshavdv There are issues related to formatting (flake8) that need to be resolved before merging this. However, IMO they should not be part of this PR.
If you merged this PR, I will create an new branch dedicated to fixing the formatting and linting issues.
@keshavdv Any change you can merge this PR so I can continue to contribute to the CI process?
Related #276. Closes #287.
Removed Typing:
Dict
~dict
Tuple
~tuple
Combined:
setup.py
setup.cfg
pyproject.toml
Bumped actions:
ci.yml
image.yml
Different version of Python were used (or defined) in various locations. Restructured to use Python 3.9 everywhere. This will also resolve the following issue with the
pyunifiprotect
package: