search

keshavdv / unifi-cam-proxy

Enable non-Ubiquiti cameras to work with Unifi NVR
MIT License
1.72k stars 236 forks source link

Add support for HTTP BASIC AUTH #72

Closed 5thsymphony closed 3 years ago

5thsymphony commented 3 years ago

I needed basic auth so I added it, bit of a hacky way of doing things though. Is there a better way?

5thsymphony commented 3 years ago

This is slightly less hacky now but it still doesn't feel quite right.

keshavdv commented 3 years ago

Looks good, just a couple of notes:

  1. What error do you see without this PR?
  2. Rather than splitting the URL yourself, can you use the urlparse module to extract the relevant information?
stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.