search

keshavdv / victron-ble

A Python API to parse Victron Instant Readout BLE advertisements
The Unlicense
96 stars 33 forks source link

Add dcdc converter #16

Closed humppafreak closed 1 year ago

humppafreak commented 1 year ago

Summary :memo:

Added support for Orion Smart DC/DC chargers

Details

Describe more what you did on changes.

  1. Added all Orion Smart product IDs to devices/base.py
  2. Wrote parser logic to parse datagrams from Orion Smart DC/DC Converters.
  3. Checked against live device on our boat, input/output voltage and operation mode match what's shown in the VictronConnect app.

Checks

keshavdv commented 1 year ago

This looks great, can you add some new unit tests with some sample broadcast data so we can validate the output?

humppafreak commented 1 year ago

Sure can do. I'll add the respective unit tests in the next couple of days.

keshavdv commented 1 year ago

I added a version of this in 88bc24c2e8ac854890207fb745c52e89419fd8c9 with a really basic test and some real data