search

kesiev / akihabara

A game engine for making classic arcade style games using Javascript and HTML5. We're starting moving on a re-organized repo here: https://github.com/akihabara
http://www.kesiev.com/akihabara
GNU General Public License v2.0
529 stars 53 forks source link

Cleanup for the Leave Me Alone demo #13

Closed andrewrabon closed 13 years ago

andrewrabon commented 13 years ago

Basically what I did was separate the LMA code into its own file, to make it easier to work with. I then started cleaning up the code in accordance with general JS best practices (using === instead of ==, adding missing semicolons to the ends of functions and other statements, making sure all anonymous functions return something, etc.) Finally I did some minor stylistic changes such as fixing all the indentation (and making it consistent, it uses tab stops) and adding spaces to several places, making the code easier to read.

This is just the start of my contributions to Akihabara. I'm Andrex from the forums, by the way.

kesiev commented 13 years ago

Hi! Excuse me for the quick answer (@ work ;) ) but, since Akihabara is seeing something like a repository splitting and your work is quite interesting, I think that can be useful to say in advice that you can find the new akihabara repo here: https://github.com/akihabara Is still not official, since I've not tried to work with this splitted up repo (splitted by PotHix in order to separate demos for core) but you can give a shot to that repo and try to commit your changes there - and give us some feedback on that :) For now should be the same latest version of the core.

andrewrabon commented 13 years ago

Oh thanks! I didn't even know about that. I'll definitely get on that, then!