search

kesiev / akihabara

A game engine for making classic arcade style games using Javascript and HTML5. We're starting moving on a re-organized repo here: https://github.com/akihabara
http://www.kesiev.com/akihabara
GNU General Public License v2.0
529 stars 53 forks source link

Made relative path option #16

Closed shamess closed 11 years ago

shamess commented 13 years ago

I added a relative path option to gbox. This hasn't changed any logic anywhere, but it allows me to put the library anywhere I like (in a /lib/ folder, specifically). You set the gbox._relpath option before any calls to the libraries, including help.

Previously, loadAll() wouldn't to find the debug font if the directory was anything buy akihabara/, and silently fail. There's also a few places where I expect the same would happen in the help.js script too, so I've changed those. I didn't see any other references to "akihabara/" elsewhere that would need changing.

kesiev commented 13 years ago

Hi shamess! Thank you for the patch. I suggest you to make the relative path configurable from the help.akihabaraInit (it configures gbox quite like you did) and move your patch to the new official repository https://github.com/akihabara/akihabara. There currently are two repos since the older one wasn't already tested on all real devices but is more tidy and well organized. Thank you again!

PotHix commented 13 years ago

s/older one/new one/g

PotHix commented 12 years ago

Hi @shamess, can you submit this patch on the new Akihabara repository as a configurable parameter? Contact me on any doubt :) The new repository is this one https://github.com/akihabara/akihabara.

@kesiev Can we close this issue?