search

kesselborn / conex

Firefox extension
Mozilla Public License 2.0
174 stars 16 forks source link

On enter, automatically open top most hit #195

Closed psamim closed 6 years ago

psamim commented 6 years ago

Hi,

When I want to go to a container, I hit ctrl-space, start typing "Wo", "Work" appears at the top of list as the first match. I expect by hitting enter I can go to the first result, which is "Work". But actually I have to hit one extra tab key to select (activate) the first result and then hit enter.

Can we remove the need for that one extra tab key?

Thanks

kesselborn commented 6 years ago

Yup ... good one I thought about as well :)

Am 16.03.2018 um 06:12 schrieb Samim Pezeshki notifications@github.com:

Hi,

When I want to go to a container, I hit ctrl-space, start typing "Wo", "Work" appears at the top of list as the first match. I expect by hitting enter I can go to the first result, which is "Work". But actually I have to hit one extra tab key to select (activate) the first result and then hit enter.

Can we remove the need for that one extra tab key?

Thanks

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

grahamperrin commented 6 years ago

I expect the initial Tab to focus on the disclosed container – as it already does … sometimes.

Expected, when focus (after one Tab) is on the container

Actual result, when focus is on the container

Other times

The initial Tab unexpectedly skips the disclosed container, focuses on what's below.

kesselborn commented 6 years ago

mmm ... I think I understand what you mean. The behavior at the moment is as follows:

When a search was started, containers can only be focused if the search matches their title, otherwise you focus the first tab within the container that matches the search.

I.e.: if you have a container called "news" with a tab that has "news.cnn.com" open and you search for "cnn", the container will not get the focus as the search does not match. If you searched for "news", both elements, container and the tab, would be focusable, as "news" matches both items.

I created a followup issue for this: kesselborn/conex#205