search

kesselborn / conex

Firefox extension
Mozilla Public License 2.0
174 stars 16 forks source link

`about:addons`, `about:preferences`, and other `about:*` pages don't open when selected #197

Closed opes closed 6 years ago

opes commented 6 years ago

When trying to open a new tab with an about: page that has been bookmarked, nothing happens. However, if the tab is already open, then it will switch to it as expected. I thought it might have something to do with https://github.com/kesselborn/conex/blob/ef9438510a6d6151558cf042abbe0a5a3c8b2949/conex-background.js#L298, but testing it with about:newtab exhibits the same issue. I haven't investigated fully, though, so that may be a red herring.

kesselborn commented 6 years ago

mmm ... I either don't understand the bug report or can't recreate it. What do you mean with "trying to open a new tab"? Like: switching to it with the conex popup? Or opening it from the bookmarks menu? Which version of conex are you running?

Thanks for the report, Cheers

opes commented 6 years ago

Apologies for the poorly worded report. I'm using Conex 0.5.24 for Firefox Nightly on Windows 10. Here are the repro steps:

Repro Steps

  1. Bookmark about:addons
  2. Invoke the Conex popup
  3. Search for your about:addons bookmark in Conex
  4. Tab to the entry listed under the bookarks section
  5. Hit Enter

What Happens:

Expected Result:

opes commented 6 years ago

After looking into it more, this may actually be a limitation of Firefox add-ons not having the permission to open most about: pages (though I haven't yet pinpoint where in the documentation it has that restriction stated).

kesselborn commented 6 years ago

yeah ...sorry for the late reply: this is a Firefox limitation and I am pretty certain due to security versions (otherwise external pages could probably open a about:... page and manipulate it via JavaScript. If this limitations wasn't there, I would for example just link to the container preferences page.

Need to close this as I can't fix it, sorry

opes commented 6 years ago

Thanks for looking into this more, by the way. Appreciate the hard work put forth on Conex!