kesselborn / conex

Firefox extension
Mozilla Public License 2.0
174 stars 16 forks source link

Opening new tabs always opens in the default container instead of current container #219

Closed gee-forr closed 6 years ago

gee-forr commented 6 years ago

Hi @kesselborn, all,

I've got some weird behaviour with Conex... I see in the preferences for it, it says that CMD+T will open a new tab in the current container. Unfortunately, everytime I open a new tab, it switches back to the default container, and once I've entered an address, I am presented with the dialog for choosing which container to open the tab in.

What I was expecting instead was this: Go to my container, CMD+T, enter address, view page within that container.

I was under the impression that I would only see the "choose container" dialog when opening new external links?

It should also be noted that if I'm in the default container, creating a new tab, works as per normal.

My setup is as follows:

gee-forr commented 6 years ago

Quick update... I suspected that it might be tab center redux interfering with things, but unfortunately, that didn't turn out to be the case :(

kesselborn commented 6 years ago

weird ... interference wth tab center redux would have been my guess as well. I am currently on Beta, need to install Nigthly again and check. Thanks.

msdobrescu commented 6 years ago

Hi, on my Firefox 59 64 bit under Linux Sabayon it happens the same and I don't have tab center redux.

gee-forr commented 6 years ago

Uhhh... so, I mentioned that "It should also be noted that if I'm in the default container, creating a new tab, works as per normal.". This turns out not to be the case.

Even if I'm in the default container, I'm still presented with the container selection dialog.

kesselborn commented 6 years ago

mmm ... quick test with nightly under mac os x does not show this behavior. Do you have any other extensions installed? If yes, which are those? Especially extensions which fiddle around with new tabs can interfere with conex. The mechanism to open tabs in the same container is, due to technical limitations, quite a hack. Furthermore, perhaps it already helps, if you disable the option " ask in which container to open external links instead of always using the current container ".

gee-forr commented 6 years ago

Rats... I've disabled all other extensions besides conex and tcr, and it's still presenting the dialog when entering an address.

If I'm only running conex and tcr, and I disable the "ask in which container to open external links instead of always using the current container", then when I "CMD+T", it opens a fresh tab in the default group, and after entering the address, it warps back to my current container and opens it fine.

I'm going to selectively enable my other extensions to see if there's a conflict there.

gee-forr commented 6 years ago

Urgh - bizaare... disabling the " ask in which container to open external links instead of always using the current container " toggle works with all my addons. It wasn't before. I feel like I'm losing my mind.

I'm willing to live with external links opening in the wrong container for now, but hopefully you'll be able to get to the bottom of this.

Let me know if I can give you any more data to help you out.

kesselborn commented 6 years ago

Urgh - bizaare... disabling the " ask in which container to open external links instead of always using the current container " toggle works with all my addons.

what does that mean exactly? That tabs are opened in the current container when using CTRL-T? Note: on Linux it's CTRL-T ... just to be sure ;)

gee-forr commented 6 years ago

Sorry, upon rereading that, I see I wasn't super clear... lemme clarify:

Previously, with "ask in which container to open external links instead of always using the current container", it would do all of the above, but also ask me which container I wanted to load www.cnn.com in.

Also - what I meant by "with all my addons", is that I switched off all my addons, toggled the "ask in which container to open external links instead of always using the current container" feature off, and then tested the above steps.

I gradually reenabled all my addons, and retested the above steps, until all my addons were once again enabled.

Here's all my addons, btw.

screen shot 2018-05-04 at 10 59 14

kesselborn commented 6 years ago

Thanks for clarifying. This is even weirder than I understood before :D

On 4. May 2018, at 10:30, Gabriel Fortuna notifications@github.com wrote:

Sorry, upon rereading that, I see I wasn't super clear... lemme clarify:

I have disabled the "ask in which container to open external links instead of always using the current container" toggle I'm in container "foo", and I CTRL-T Firefox warps to the default container I enter www.cnn.com http://www.cnn.com/ Firefox warps back to container "foo" www.cnn.com http://www.cnn.com/ loads in container "foo" Previously, with "ask in which container to open external links instead of always using the current container", it would do all of the above, but also ask me which container I wanted to load www.cnn.com http://www.cnn.com/ in.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kesselborn/conex/issues/219#issuecomment-386536630, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAvjX-xkPbZJY7x86QdGEsHrn-5L-wqks5tvBGLgaJpZM4Tw4Oj.

Mikanoshi commented 6 years ago

Internal Firefox tabs (Options, Add-ons, etc) are always opening in Default. Ctrl+T 99 times out of 100 opens new tab in the same container, but at the end, not after the current tab, and 1 time in Default. Extensions like "Open Tabs Next to Current" or "Always Right" have no effect on Ctrl+T inside containers :( Opening new tab in container by pressing + in Conex menu opens it next to current if relevant extension is active.

[rant] Also, why not make an option to not use containers? That privacy stuff just pisses me off, I don't need it, I don't want tab groups to be like different browsers. If I login on any site in one group I should stay logged in in all groups. But it was rejected already :) https://github.com/kesselborn/conex/issues/192

And ANY of my opened tabs must be next to current AT ALL TIMES! No idea why it is so hard that you need to write whole extensions for that, beg Mozilla to implement this basic stuff and still have it all broken as hell... [/rant]

FunkMonkey commented 6 years ago

I have the same problem (FF 60.0.1). Sometimes when a open a new tab using CTRL-T in Group B, it first opens in the Default Container, I type something, it asks which group to open the tab in, I choose Group B and it jumps there, but then won't even open the tab there. The new tab will simply be gone.

Sometimes I even have the problem after I disabled "ask in which container to open external links", that the container jumps and the new tab gets lost...

Thanks for the help...

msdobrescu commented 6 years ago

Also, here and Firefox property pages (for settings, addons etc.) are opened in the default container. If you ask me, they should be isolated from any other container.

FunkMonkey commented 6 years ago

Now I had an interesting situation. I was in the default container and wanted to open a bookmark from the bookmark bar in a new tab using middle mouse button. The tab opened for a second and closed itself again. For fun I did it a couple of times in a row. Around the 7th or 8th time the tab stayed open.

Also, opening links from an already opened tab using middle mouse button (so child tabs) always works. Hmm. anyone else using Tree Style Tabs? Maybe it's not working well together...

All tested with ask in which container to open external links disabled...

Mikanoshi commented 6 years ago

I don't observe such behavior, opens every time (no Tree Style Tabs installed). I'm on FF 61.0b7 with new pref browser.tabs.insertAfterCurrent = true, it's like FF devs have read my rant above :) Ctrl+T works fine now and always opens new tab in current container next to current tab (tabstrip is being scrolled to this new tab for some reason, but still it's a step forward).

FunkMonkey commented 6 years ago

Update: Today everything works as expected. I am still on the same Firefox version. uBlock is the only extension that was updated in the meantime...

kesselborn commented 6 years ago

hey: sorry for the very late reply: I was kind of off the grid for a while :/

Can I close this? .... from the last comment it seems like it

gee-forr commented 6 years ago

Hey @kesselborn - please don't apologise... you're doing this on your own, so we have no expectations. Any support at all is appreciated.