search

kesselborn / conex

Firefox extension
Mozilla Public License 2.0
174 stars 16 forks source link

update last used container when window is focused (not just tab) #246

Closed smichel17 closed 5 years ago

smichel17 commented 6 years ago

Preface: I thought this had already been discussed in another issue, and the outcome was "can't fix." However, I wasn't able to find that issue, so here's a new one.

Simple to reproduce:

  1. Open one window with a bunch of tabs in container A
  2. Open a second window with a bunch of tabs in container B
  3. Arrange the windows so both are visible
  4. Select a tab in window 1 (container A).
  5. Click the + button in window 2 (container B).

Expected result: New tab in window 2 is in container B Actual result: New tab in window 2 is in container A

On its own, this would not be too bad. However, the actual problem comes here:

Modified steps to reproduce:

  1. Open one window with a bunch of tabs in container A
  2. Open a second window with a bunch of tabs in container B
  3. Arrange the windows so both are visible
  4. Select a tab in window 1 (container A).
  5. Give window 2 focus without clicking on a tab or page. Ex: clicking the title bar or alt-tabbing
  6. Click the + button in window 2 (container B).

Same results

This is a problem because window/tab that has focus when clicking the + button actually is in container B, but the new tab is opened in container A.

I can think of two scenarios:

  1. Webextensions are missing a callback, so conex can't know that window 2 (and thus, a tab in container B) is focused. We should file a bug upstream.
  2. There's some focus-related callback that conex should be tracking.
smichel17 commented 6 years ago

Possible duplicate of #193 of #238?

kesselborn commented 6 years ago

hey: sorry for the very late reply: I was kind of off the grid for a while :/

excellent: thanks for the steps to reproduce the problem

msdobrescu commented 6 years ago

A related behavior is when you drag atab outside of the current window. The new window becomes marked as the container of that tab. When there are several tabs in that container, they remain in the initial window, which is desired. If the current container is changed, the tabs become inaccessible in the original window, when I try to come back to the initial container in the original window as long as the second window is opened. I'd like to select the desired container in any window, anytime.

kesselborn commented 5 years ago

@msdobrescu what you are describing is a duplicate of #193

The original bug report is a different issue ... I will adjust the title accordingly