Ctrl+t / Cmd+t + new (blank) tab = Bug

kesselborn / conex

Firefox extension

Mozilla Public License 2.0

174 stars 16 forks source link

Ctrl+t / Cmd+t + new (blank) tab = Bug #252

Open JibsouX opened 6 years ago

JibsouX commented 6 years ago

Hello ! I have found a little bug ^^ :

1 - Select blank tab in the general settings :

2 - Try to open new tab in a container = the new tabs are always open in the default container

Tx for your hard work on this plugin !

++ I have a little idea also : it will be a good thing to have a setting to auto-open the container list that i consult (on the popup)

kesselborn commented 6 years ago

hey, thanks for the report... will have to try to recreate it.

I don't really understand the idea you are describing :/

JibsouX commented 6 years ago

Sorry i will try to explain better 👍

Say i have container 1, 2, 3, i'm on a tab in the container 2
When the container list (popup) is shown (open), the dropdown list of the container 2 is open at the active tab

a little tweak also : in the container list popup when the search area is fill it will be perfect if it auto select the first tab found because now we have to tap 'key-down' to select it then tap 'enter' to activate the tab

Tx a lot in advance !!

dmusican commented 5 years ago

I just saw this same bug. @JibsouX ; thanks so much for posting this so I knew how to work around it. I'll try to explain again also: when using ctrl-t to open a new tab, it doesn't open in the current container like it should .... if in preferences, the new tab is set to a blank page.

JibsouX commented 5 years ago

Firefox 65.0.1 : The bug has make a come back lol !

kesselborn commented 5 years ago

mmm ... the current code has reached its limits. I will do a bigger rewrite which should hopefully fix a bunch of problems currently present. Bad news though: this will probably take a while :/

JibsouX commented 5 years ago

Thanks a lot for yr hard work ! best plugin since tabgroup !

kesselborn commented 5 years ago

That’s quite a compliment, thanks!

On 19. Feb 2019, at 22:48, JibsouX notifications@github.com wrote:

Thanks a lot for yr hard work ! best plugin since tabgroup !

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/kesselborn/conex/issues/252#issuecomment-465324651, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAvjSsmyHapQHjLaX-Z6Kc01HeY07R-ks5vPHFDgaJpZM4VxWAG.

capi1O commented 5 years ago

First thanks for finding this bug because at first I thought conex was not working (I use it solely to open new tab in container with ctrl+T).

This bug also prevents ctrl+T to open in current container if an extension is used to customize new tab page (ex New tab override, Custom New Tab Page, New Tab Tools ...)