search

kesselborn / conex

Firefox extension
Mozilla Public License 2.0
174 stars 16 forks source link

New tab no longer keeps focus in address bar #258

Closed bkahne closed 5 years ago

bkahne commented 6 years ago

I'm not sure when it started happening, but using Firefox Nightly 63.0a1 with Conex 0.7.11, when I open a new tab, the focus is no longer in the address bar. Previously, I could press Ctrl-T and then just start typing a new address, which was really convenient. I verified that this is an issue caused by Conex by disabling all extensions, then adding them back one-by-one.

Is this a known issue? It seems like it just started happening a month or so ago, so could something have changed?

cr0ybot commented 6 years ago

Having the same issue here, on Firefox Dev Ed. 63.0b2 and Conex 0.7.11. I verified that a new tab does put focus in the address bar in the "default" container, but not for any other containers.

Might be related to this discussion on Mozilla Discourse which links to this bit of code in an extension that determines where to place focus in a new tab.

kesselborn commented 6 years ago

meeehh.. yup: seeing the same issue here now after update to 63 came in. Thanks for the issue!

kesselborn commented 6 years ago

so: I am not that this is somehow fixable but rather intentional behavior (see https://discourse.mozilla.org/t/focus-page-instead-of-address-bar-on-new-tab/29592/5 and https://bugzilla.mozilla.org/show_bug.cgi?id=1458842 )

However: setting the "Home / New Tabs" setting to "Blank Page" instead of "Firefox Home" fixes the behavior for me

kesselborn commented 6 years ago

mmm ... seems as if I wasn't right about this as now but #252 is triggered :(

bkahne commented 6 years ago

Yes- just tried it and I see the same behavior: I press Ctrl-T and I get a new tab, with the correct focus, but it always opens in the default container.

kesselborn commented 6 years ago

opening new tabs in the current container is the nastiest part of this extension as there is not nice way to do it ... I am really annoyed :D

Mikanoshi commented 5 years ago

Fixed in 63.0 beta 8?

bkahne commented 5 years ago

I just tried it on 64.0a1 (2018-09-24) and it does appear to be fixed.

cr0ybot commented 5 years ago

On 63.0b11 (Mac), bug does indeed appear to be fixed. Ctrl-T in container opens a new tab correctly in the container, and address bar is focused.

kesselborn commented 5 years ago

Thanks — that so really good news as I did not have any clue on how to fix that (tried several hacks). Thanks for coming back

Am 04.10.2018 um 16:10 schrieb Cory Hughart notifications@github.com:

On 63.0b11 (Mac), bug does indeed appear to be fixed. Ctrl-T in container opens a new tab correctly in the container, and address bar is focused.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.