kesselborn / conex

Firefox extension
Mozilla Public License 2.0
174 stars 16 forks source link

Conex lost some features #281

Open msdobrescu opened 5 years ago

msdobrescu commented 5 years ago

Hello, I use Linux Sabayon (64-bit), up to date. I have noticed that conex can't be added to the address bar as page action anymore. Also, lost the ability to move a page between containers. I don't know if it is Linux related, I see in Firefox (64.0, 64 bit) a message stating "Your organization has disabled the ability to change some options". I don't know if it is related. Sorry if it is not a bug, but it worked differently before.

kesselborn commented 5 years ago

Hey: that is intentional. Firefox now has a built in "Reopen in Container" menu entry if you right-click on a tab which is pretty close to what conex provided (it does not close the original container though). I don't want to duplicate core functionality so I removed the code from conex (which was a lot of code and hence cleaned up the code base quite a bit). This was a very recent change (2 days ago).

msdobrescu commented 5 years ago

You mean it does not close the original page in the original container. It is highly inconvenient. Is it possible to override that? At least, using the Firefox API, add a new menu "Move to container" that closes it? This is needed rather than copying it in another container. I know it is not expected, but I need this many times a day. Also moving many tabs at once is easy to manage them sometimes, but in "all to the right" or "all to the left" way. Another annoyance is the lack of containers sorting alphabetically in that native menu.

msdobrescu commented 5 years ago

Actually, after the big change of add-ons API, I am still suffering a lot, Firefox is simply dumbed down from a great tool, which is more than a browser, to a basic thing without hope of going back to what it was at all. There is still missing a good download tool able to parse a page and extract properly the links, with anti container and saving to a place of choice. Professionally, conex was enough to group my projects and points of interest and makes Firefox bearable as cut down as it is now. As software developer myself I understand your pressure. And as doing yourself person that shares the work with the world is one of the most to be respected things. Still, don't hit us again, after a few days of using Firefox's way of sending the tabs to other container, I find so difficult to manage it needing to remember where and what to close after. Also selecting each time the container to open the tab is so annoying, not needing that in 80% of the cases... This change turned down the comfort considerably...

kesselborn commented 5 years ago

Actually, after the big change of add-ons API, I am still suffering a lot, Firefox is simply dumbed down from a great tool, which is more than a browser, to a basic thing without hope of going back to what it was at all. There is still missing a good download tool able to parse a page and extract properly the links, with anti container and saving to a place of choice. Professionally, conex was enough to group my projects and points of interest and makes Firefox bearable as cut down as it is now. As software developer myself I understand your pressure. And as doing yourself person that shares the work with the world is one of the most to be respected things. Still, don't hit us again, after a few days of using Firefox's way of sending the tabs to other container, I find so difficult to manage it needing to remember where and what to close after.

yeah: I actually have to agree on that :/. Perhaps there is a way to use the Firefox reopen-feature and then closing those tabs automatically (please feel free to create an issue for that — I will prioritize it as I am myself annoyed by the fact that those tabs stay open). Apart from that, the Firefox “reopen”-feature solved some things that conex didn’t (moving to a default container, moving multiple tabs at the same time and some race conditions). I think trying to automate closing the reopened tabs could be possible and would have the both of the two approaches. For the time being: it’s possible to install an older version of conex — perhaps that’s an ok approach for 2 weeks? Can’t work on conex for the next 1 1/2 weeks, but this will be the thing I will look into.

Also selecting each time the container to open the tab is so annoying, not needing that in 80% of the cases…

? I don’t understand what you are describing here

This change turned down the comfort considerably...

yeah … agreed

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/kesselborn/conex/issues/281#issuecomment-451773794, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAvjcS54y6-8eF3SHnUH8bxnoeM3cBzks5vAmITgaJpZM4Zwubj.

msdobrescu commented 5 years ago

And I have noticed some strange behaviour. It opens the tab in the default container then moves it to the current container. An annoying dance I've seen in the past, that makes me wonder how much data was disclosed to other container. I presume this is Firefox. Also, after closing the last tab in a container, I see it landing in other container... It should stay in the current container...

kesselborn commented 5 years ago

On 6. Jan 2019, at 22:02, Mihai Sorin Dobrescu notifications@github.com wrote:

And I have noticed some strange behaviour. It opens the tab in the default container then moves it to the current container.

“it” as in the Firefox “reopen in container” functionality?

An annoying dance I've seen in the past, that makes me wonder how much data was disclosed to other container.

Conex works this way, yes — that’s why it had a big, fat disclaimer about that (which I removed by error)

I presume this is Firefox. Also, after closing the last tab in a container, I see it landing in other container... It should stay in the current container...

this is a bug … could you file an issue for that please? Or does this happen without conex as well?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/kesselborn/conex/issues/281#issuecomment-451774561, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAvjbIR6yiQtUsGkS62ymyJWCKQqadIks5vAmRjgaJpZM4Zwubj.

msdobrescu commented 5 years ago

Also selecting each time the container to open the tab is so annoying, not needing that in 80% of the cases… ? I don’t understand what you are describing here

I mean to use "ask in which container to open external links instead of always using the current container" option.

msdobrescu commented 5 years ago

On 6. Jan 2019, at 22:02, Mihai Sorin Dobrescu @.***> wrote: And I have noticed some strange behaviour. It opens the tab in the default container then moves it to the current container. “it” as in the Firefox “reopen in container” functionality?

Actually, I don't know. It does not happen always. I've noticed one sure case, when I use the search bar and press enter.

An annoying dance I've seen in the past, that makes me wonder how much data was disclosed to other container. Conex works this way, yes — that’s why it had a big, fat disclaimer about that (which I removed by error) I presume this is Firefox. Also, after closing the last tab in a container, I see it landing in other container... It should stay in the current container... this is a bug … could you file an issue for that please? Or does this happen without conex as well?

kesselborn commented 5 years ago

On 6. Jan 2019, at 23:40, Mihai Sorin Dobrescu notifications@github.com wrote:

Also selecting each time the container to open the tab is so annoying, not needing that in 80% of the cases… ? I don’t understand what you are describing here I mean to use "ask in which container to open external links instead of always using the current container" option.

?? … so then don’t enable this option?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/kesselborn/conex/issues/281#issuecomment-451781913, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAvjYCSk-2H1GdLJRiZeDtwnI1zHUDLks5vAntUgaJpZM4Zwubj.

kesselborn commented 5 years ago

On 6. Jan 2019, at 23:47, Mihai Sorin Dobrescu notifications@github.com wrote:

On 6. Jan 2019, at 22:02, Mihai Sorin Dobrescu @.***> wrote: And I have noticed some strange behaviour. It opens the tab in the default container then moves it to the current container. “it” as in the Firefox “reopen in container” functionality?

Actually, I don't know. It does not happen always. I've noticed one sure case, when I use the search bar and press enter.

sorry: that is very vague

An annoying dance I've seen in the past, that makes me wonder how much data was disclosed to other container. Conex works this way, yes — that’s why it had a big, fat disclaimer about that (which I removed by error) I presume this is Firefox. Also, after closing the last tab in a container, I see it landing in other container... It should stay in the current container... this is a bug … could you file an issue for that please? Or does this happen without conex as well? … <x-msg://23/#> — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/kesselborn/conex/issues/281#issuecomment-451782443, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAvjTyy_WsduyYI-Tio0drNKkqf1Olnks5vAnzogaJpZM4Zwubj.

msdobrescu commented 5 years ago

I go to the search bar of Firefox, write to search something, press enter, opens a new tab that appears to be in the default container, then moves back to the initial container. Also, I've found another similar behaviour, possibly having the same reason. Press Ctrl+T opens a new tab, but not in the current container, it opens a new tab in the default container, I think. I am not sure because there is a default container where I have opened some certain page, but there is no container name or icon. So, assuming it is the default container, it stays there empty until I write something in the search bar and press the arrow that starts the search. At this moment the empty tab is populated with a page and moves back to the initial container!

msdobrescu commented 5 years ago

Hi, I know it is closed, but I am not sure if a new issue should be added. I see you implementing moving to another container works pretty much. Still, in my experience, on 64.0.2 4-bit, I have a glitch. It moves, goes to the new container, but - at least in my case, the tab to the right remain drawn on the tab bar, although was did not moved. Then, at the first click, FF is redrawn, so the tab is no more there. Also, one of the best features is no more, the moving of tabs from a container without moving FF to that container, if the tabs in question are not current. That makes it hard sometimes to move several tabs.

kesselborn commented 5 years ago

The glitch that you have more than one container visible is (at the moment) by design ... have to think whether I will change that. Moving several tabs at the same time: this is much better now: in Firefox, you can select multiple tabs by pressing CTRL (or CMD on the Mac) and move all those tabs at the same time.

kesselborn commented 5 years ago

blocked by #304