search

kesselborn / conex

Firefox extension
Mozilla Public License 2.0
173 stars 16 forks source link

After closing the last tab in a container, switches to other container #286

Open msdobrescu opened 5 years ago

msdobrescu commented 5 years ago

Hello, after closing the last tab in a container, I see it landing in other container. It should remain in the current container.

kesselborn commented 5 years ago

could you do a screenrecording of this? I can't recreate this and it's hard to imagine how this should happen

msdobrescu commented 5 years ago

I've never recorded and I have no idea where to put it. I don't have file share accounts. My steps are simple. Have a container with one tab with some page content (like search). Close the tab. The container is switched to other (possibly the next or the previous in the list). Nothing fancy. I use Firefox 64, 64-bit, on Linux Sabayon.

kesselborn commented 5 years ago

ah, ok: so you are in a different container, but the tab you just closed is not re-opened in that container? … that’s how I understood it (and hence was confused)

On 7. Jan 2019, at 00:27, Mihai Sorin Dobrescu notifications@github.com wrote:

I've never recorded and I have no idea where to put it. I don't have file share accounts. My steps are simple. Have a container with one tab with some page content (like search). Close the tab. The container is switched to other (possibly the next or the previous in the list).

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/kesselborn/conex/issues/286#issuecomment-451785438, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAvjQQU5GMktLGjNlS90a6yxM_Z8gXGks5vAoZRgaJpZM4ZypY5.

msdobrescu commented 5 years ago

This is not about re-opening or moving. I just close the last tab in a container (A) and the browser moves to another container (B). If I want to open a new tab in the first container (A), I have to switch to that container (A), because it is in other container now (B). It should stay in the current container all the time.

kesselborn commented 5 years ago

mmm ... ok: this is actually as intended. Now that you say it -- perhaps there should be a dialog if the user wants to discard the container and if they chose not to, create a new, empty tab there.

msdobrescu commented 5 years ago

What do you mean by discarding? The container remains there, kind of empty. It is not deleted and should not be. For me, it's like the old Firefox, back when no containers existed, and there was an option, to close Firefox or not, depending on the user setting, no dialog for that. For that case, several options were present (I think they still are). To open an empty tab or to open the home page or to close the browser etc.. Should be like this here, but avoid closing or deleting or switching the container, especially when the user does not want to land in a random container. I don't even use the default container, so that would be an option at best.

capi1O commented 5 years ago

Any updates on this @kesselborn ?

I don't know if this can be addressed by conex (or only by multi-account-containers itself), but it is annoying when it switches back to a different container than the current one, especialy when the tab bar is hidden.

to make it clearer it is Firefox default behaviour to switch back to last created tab when current one is closed, but with containers it could be nice to have an option to switch back to last created tab in current container only.