search

kesselborn / conex

Firefox extension
Mozilla Public License 2.0
173 stars 16 forks source link

Tree Style Tab & Connex - open external link bug #303

Open rdewolff opened 5 years ago

rdewolff commented 5 years ago

After a fresh Firefox install, if I install Connex and Tree Style Tab plugin, I cannot open external clicked links.

When I click a link in another program, Firefox gets the focus, opens the tab, and closes the tab. All this very quickly.

Could you check this please?

kesselborn commented 5 years ago

what are your settings regarding "ask in which container to open external links instead of always using the current container"?

rdewolff commented 5 years ago

Just a note: if I disable Conex, the issue does not happen anymore.

rdewolff commented 5 years ago

what are your settings regarding "ask in which container to open external links instead of always using the current container"?

I have tried both settings, and they both do not work.

kesselborn commented 5 years ago

Ok, thanks. Note though that compatibility with TreeStyleTabs is not high on the priority list atm.

On 22. Feb 2019, at 11:35, Rom notifications@github.com wrote:

what are your settings regarding "ask in which container to open external links instead of always using the current container"?

I have tried both settings, and they both do not work.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/kesselborn/conex/issues/303#issuecomment-466352451, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAvjT-Lt-MYr4tydzI6AuAIsk77mwUeks5vP8fjgaJpZM4bJT5z.

piroor commented 5 years ago

After testing I've realized why this happens on a case. https://github.com/kesselborn/conex/blob/master/conex-background.js#L467 Conex tries to open a new tab as a "child" of the original tab, and immediately closes the "parent" tab after the child is opened. On the other hand, TST automatically attaches the new "child" tab to the "parent", but its tree is internally still collapsed. Because the "parent" tab is closed before it becomes expanded, TST closes all children in the collapsed tree.

I think this problem must be fixed by TST side.

rdewolff commented 5 years ago

Thanks for the answer @piroor. I have updated the ticket https://github.com/piroor/treestyletab/issues/2162 and added your feedback. Let's hope someone can fix it🤞

piroor commented 5 years ago

This problem should be fixed by the commit: https://github.com/piroor/treestyletab/commit/223337498a9f1ab83e1edba4212cd7d380587f62