kesselborn / conex

Firefox extension
Mozilla Public License 2.0
173 stars 16 forks source link

refactoring #304

Open kesselborn opened 5 years ago

kesselborn commented 5 years ago

This is a placeholder card as this will fix a bunch of other issues. Conex will change how it works. Right now, the popup is recreated on every call. This will be changed to keeping a rendered page in the background which will just be moved to the popup when the popup is opened. This will further allow a sidebar version of conex and should dramatically improve the performance. Thumbnails will be scaled down.

rhavern commented 5 years ago

At the end of this effort, will Conex work how it used to before the recent Firefox changes to containers? Do I need to install Multi-Account Containers to get the functionality that was removed from Conex? Thanks for persevering!

kesselborn commented 5 years ago

Which removed functionality are you referring to? And Multi-Account Containers is not (and was never) a requirement for Conex.

Cheers

At the end of this effort, will Conex work how it used to before the recent Firefox changes to containers? Do I need to install Multi-Account Containers to get the functionality that was removed from Conex? Thanks for persevering!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kesselborn/conex/issues/304#issuecomment-475292084, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAvjUPKHGSSsa2Xy4ulCvyrgmzmOZkXks5vY6zegaJpZM4bJUNb.

rhavern commented 5 years ago

Hmm, now that I look at it, only one of my instances is not behaving as expected. I have "only show tabs of the current container" enabled, however all tabs continue to be visible in all containers only on this instance. I disconnected my Firefox account, deleted FF, then re-installed 60.6.1esr (64-bit), accepted that I wanted to refresh, and then reconnected to my Firefox account. My usual add-ons then installed successfully, but the behavior persisted. Other instances connected to this Firefox account appears to work correctly, however they are not on the esr branch, if that is significant.

Best regards

kesselborn commented 5 years ago

Oh .. I am not sure v60 is properly supported. Try to open about:config <about:config%60> and search for “tabhide”, this has to be set to ’true’. It’s possible, that v60 still needs manual intervention.

Cheers

On 1. Apr 2019, at 16:13, rhavern notifications@github.com wrote:

Hmm, now that I look at it, only one of my instances is not behaving as expected. I have "only show tabs of the current container" enabled, however all tabs continue to be visible in all containers only on this instance. I disconnected my Firefox account, deleted FF, then re-installed 60.6.1esr (64-bit), accepted that I wanted to refresh, and then reconnected to my Firefox account. My usual add-ons then installed successfully, but the behavior persisted. Other instances connected to this Firefox account appears to work correctly, however they are not on the esr branch, if that is significant.

Best regards

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kesselborn/conex/issues/304#issuecomment-478596223, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAvjeZqyp6Szv1mZEJSpoZdb9SHcSoIks5vchPsgaJpZM4bJUNb.

rhavern commented 5 years ago

Spot on! I had to toggle this to true, thanks for your help.

maverick74 commented 5 years ago

@kesselborn Will this also improve #215 ?

kesselborn commented 5 years ago

unfortunately not :( … this is a different problem which I can not really fix

On 5. Apr 2019, at 18:41, maverick74 notifications@github.com wrote:

@kesselborn https://github.com/kesselborn Will this also improve #215 https://github.com/kesselborn/conex/issues/215 ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kesselborn/conex/issues/304#issuecomment-480343054, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAvjZG4TJYoGgyOg6prF-w9k546vwU5ks5vd3yvgaJpZM4bJUNb.

maverick74 commented 5 years ago

It's very sad that Mozilla does not see the need for this to be fixed in a way it can be used the without problems...

oh well, maybe they'll open their eyes (on this and other "details") with the use of Chromium by the competition... either they start seeing things or they'll end up going the way of the Dodo (that that would be a shame...)

Thanks for clarifying @kesselborn :)

JibsouX commented 4 years ago

Hellow @kesselborn ! Is the refactoring is still ongoing ?

For now connex still work with ff70 but one day it will break.. :'(

kesselborn commented 4 years ago

yeah, still ongoing but lately no time to continue. The code base is much cleaner and better but performance was for unknown reasons really bad. Just tried it and it seems to be improved with the current version of Firefox. I will let it run for a few days. Regarding breaking: I use Conex daily (which is why I wrote it ;) ), so if it wouldn't work anymore, I would fix the old version, don't worry. I don't really see, why it should break in the mid term.

JibsouX commented 4 years ago

yeah, still ongoing but lately no time to continue. The code base is much cleaner and better but performance was for unknown reasons really bad. Just tried it and it seems to be improved with the current version of Firefox. I will let it run for a few days. Regarding breaking: I use Conex daily (which is why I wrote it ;) ), so if it wouldn't work anymore, I would fix the old version, don't worry. I don't really see, why it should break in the mid term.

Hy @kesselborn , Still Working on mac / FF80. But the opening of the conex popup is now way slower to show the containers.

Cheers

mkurde commented 10 months ago

yeah, still ongoing but lately no time to continue. The code base is much cleaner and better but performance was for unknown reasons really bad. Just tried it and it seems to be improved with the current version of Firefox. I will let it run for a few days. Regarding breaking: I use Conex daily (which is why I wrote it ;) ), so if it wouldn't work anymore, I would fix the old version, don't worry. I don't really see, why it should break in the mid term.

hi, @kesselborn, I assume you are NOT working with and on Conex anymore. Can you recommend a different extension with equal or better implementation of your features? Best Markus

kesselborn commented 10 months ago

I still use it daily and plan to continue with the rewrite. I am actually using the rewritten version for searching already (but that only works because I know what to look out for) ... but I don't want to make any promises, so you can as well consider it as unmaintained. Is there a real bug? Unfortunately I don't know any other extension with does Tab-Groups with containers and has a fast search for many (>1000) tabs -- which are my requirements. I tried to find a replacement but most don't do grouping with containers and none of the alternatives is fast enough :/

JibsouX commented 10 months ago

Same ! I use it every day, I have several containers and each with several tabs. I often look at the alternatives, and there's nothing identical or as well done in ui ux. i hope this plugin works indefinitely, because it's very handy for managing different accounts per container, as well as sorting and searching. Tx again !

kesselborn commented 10 months ago

yeah ... I am on it again. Once feature parity with the current plugin is reached, I will update here on how to beta test it. Thanks for the kind words :)

mkurde commented 10 months ago

I use the plugin every day and kinda depend on it. I have 6-7 groups and the main once have more than 200 tabs.

The only bug which annoys the most is that i have to click onto an external link (for example open a page from slack) up to 10 times until I get the container list instead of a blank page. I think there is some kind of race condition.

I would be more than happy to beta test the next version.

kesselborn commented 10 months ago

oh, that's interesting -- I don't have that problem. Race condition is a valid assumption: There is no easy way to find out, whether the link is external or not ... it's a wild guessing. That is one of the things I still have to implement for the rewrite :/

JibsouX commented 10 months ago

As far as I'm concerned, everything works pretty well, just a strange behavior when opening a new tab (ctrl+t or command+t for mac) the newly created tab in a container, is by default in no container then once the url is validated or a search is performed the tab is then assigned the container in question. and an option that I don't think has ever really worked for me '(experimental) close tabs that are re-opened in another container'. I'd be happy to betatester as well ;) Cheers !