search

kesselborn / conex

Firefox extension
Mozilla Public License 2.0
174 stars 16 forks source link

Bug: Container is deleted without showing confirmation dialog #308

Open ReporterX opened 5 years ago

ReporterX commented 5 years ago

Firefox 66.0.2 (64-bit) Conex 0.9.7

It simply deletes the container without any confirmation dialog (when it should) when you press the "delete" icon or "backspace" key on a container. I don't normally delete a container. A fat finger may accidentally delete it. It is pretty dangerous. I would like to hide the "delete" icon.

kesselborn commented 5 years ago

Hey, thanks for the report. This should only be the case if the container does not contain any tabs — was it an empty container?

On 9. Apr 2019, at 11:39, ReporterX notifications@github.com wrote:

Firefox 66.0.2 (64-bit) Conex 0.9.7

It simply deletes the container without any confirmation dialog (when it should) when you press the "delete" icon or "backspace" key on a container. I don't normally delete a container. A fat finger may accidentally delete it. It is pretty dangerous. I would like to hide the "delete" icon.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/kesselborn/conex/issues/308, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAvjegQPyimahpUuhtK4pMAf5k98tsTks5vfF_lgaJpZM4ckD2_.

ReporterX commented 5 years ago

Hey, thanks for the report. This should only be the case if the container does not contain any tabs — was it an empty container?

Yes it is. The confirmation dialog shows up when there is a tab.

I accidentally deleted a container which I want when using.
Empty container does not mean it is no longer used. It could mean it is not yet used on that browser session. It makes more sense to ask for confirmation even for empty containers too.
Or at least there is an option to always show confirmation dialog.
Thank you.

kesselborn commented 5 years ago

Ok: yeah, that is a feature. Both views are ok in my opinion. I am currently doing kind of a rewrite and will probably always show the confirmation dialog as it’s simpler.

Cheers, Daniel

On 11. Apr 2019, at 06:48, ReporterX notifications@github.com wrote:

Hey, thanks for the report. This should only be the case if the container does not contain any tabs — was it an empty container?

Yes it is. The confirmation dialog shows up when there is a tab.

I accidentally deleted a container which I want when using. Empty container does not mean it is no longer used. It could mean it is not yet used on that browser session. It makes more sense to ask for confirmation even for empty containers too. Or at least there is an option to always show confirmation dialog. Thank you.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/kesselborn/conex/issues/308#issuecomment-481963831, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAvjRdRw_H_qe-1TYStOqW1FxLanMA1ks5vfr6ygaJpZM4ckD2_.