search

kesselborn / conex

Firefox extension
Mozilla Public License 2.0
173 stars 16 forks source link

design overhaul & improved keyboard accessibility #325

Open JVariance opened 3 years ago

JVariance commented 3 years ago

German version: Moin, ich habe die Oberfläche moderner gestaltet inklusive eines dunklen Modus'. Die Oberfläche übernimmt standardmäßig das gewählte Thema des Systems (hell o. dunkel). Der Nutzer kann das Thema in den Einstellungen aber auch unabhängig vom Systemthema ändern. Außerdem habe ich das Erstellen neuer Workspaces rein über Tastaturbefehle ermöglicht.

English version: Hi, I did a design overhaul and integrated a dark theme. The interface takes over the system's current theme (light or dark) by default. Though the user can change the theme in conex' settings seperate from the system's one. Besides I made the creation of new workspaces possible purely with keyboard commands.

kesselborn commented 3 years ago

Hey (sticking to english so more people can follow if they wish so): thanks a lot for this pull request! I like the look much better, a very good improvement. However: Testing the extension I figured that it doesn't work anymore -- only did a really short test though. Interestingly enough, I am currently in the process of rewriting the extension. I did a full rewrite using web-components 1 1/2 years ago but the performance was not holding up. I am very confident, that the current rewrite will perform well. I am kind of sorry, that you had to dig through the old code as it was really hard to maintain. So, what do you think: it'd be possible to get your PR in and release the current version ... need to look what breaks -- did it work ok for you? Alternatively, you could rather spend the time on the new version (need to push it to github). The HTML-structure changed quite a bit and the current css uses CSS-Grid which I think is much easier to handle. The future will be the new version though, as I am developing with automated testing to make the code more maintainable.

Cheers and thanks a lot for your efforts.

JVariance commented 3 years ago

Hi again, I'm very pleased to hear that you like it. The rewrite sounds great, I could have asked about it before doing my stuff, but due to the last commit happening 1 1/2 years ago I assumed this project to rest. Too bad that I apparently broke the extension, which surprises me, because it works great for me. What in particular didn't work out for you? Counterquestion regarding your other question: How far is it to the first release candidate of your rewrite? If it's still a while to go, I would indeed love to see my changes in the current version (given that it works reliable, of course), but I understand that it's wasted time in view of an imminent new version. So if you'd push the new version to github, I'd try to transfer my changes.

Best regards