search

kessler / license-report

create a short report about a project's dependencies (license, url etc)
MIT License
227 stars 39 forks source link

Add field 'remoteVersion' to output and deprecate field 'comment' #35

Closed BePo65 closed 3 years ago

BePo65 commented 3 years ago

Add field remoteVersion and deprecated field comment - solves issue #24.

Also updated readme.md and screenshots; removed 'comment' from default output; added description for custom config file to readme (for custom field list).

kessler commented 3 years ago

LGTM!

we might need to change a major version because of this?

BePo65 commented 3 years ago

mhm, maybe.

Is this really a breaking change, as we don't remove the 'comment' field? Or more kind of an extended functionality until we finally remove the 'comment'?

I would recommend a minor version for this.

-----Ursprüngliche Nachricht----- Von: Yaniv Kessler [mailto:notifications@github.com] Gesendet: Mittwoch, 18. November 2020 04:38 An: ironSource/license-report license-report@noreply.github.com Cc: BePo65 bpottler@nexgo.de; Author author@noreply.github.com Betreff: Re: [ironSource/license-report] Add field 'remoteVersion' to output and deprecate field 'comment' (#35)

LGTM!

we might need to change a major version because of this?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ironSource/license-report/pull/35#issuecomment-729372723 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSHBQOCGKSZXVMRWVYJKI3SQM6STANCNFSM4SUM2ABQ . https://github.com/notifications/beacon/ABSHBQICK243PA4QMLQOT73SQM6STA5CNFSM4SUM2AB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFN4VQMY.gif

kessler commented 3 years ago

Yup, minor it is