search

kessler / license-report

create a short report about a project's dependencies (license, url etc)
MIT License
226 stars 39 forks source link

Allow fetching license info from `peerDependencies` and `optionalDependencies` #63

Closed pubmikeb closed 2 years ago

pubmikeb commented 3 years ago

Add support of peerDependencies and optionalDependencies.

Reference: https://github.com/ironSource/license-report/issues/61

pubmikeb commented 3 years ago

@BePo65, could you, please, have a look why the _Node.js CI / build (10.x) (pullrequest) is failed? I don't see any suspicious points there. It looks like the DevOps/Mocha configuration issue, rather than the PR issue.

Thanks.

BePo65 commented 3 years ago

That is my fault: I updated mocha to version 9 just to fix an issue from the github dependabot and here mocha dropped support for node v10 (as this felt out of LTS in march). I didn't find the time to clear this with Yaniv and to drop the v10 support from the github actions.

So with your PR everything is fine,don't worry.

pubmikeb commented 3 years ago

That is my fault: I updated mocha to version 9 just to fix an issue from the github dependabot and here mocha dropped support for node v10 (as this felt out of LTS in march). I didn't find the time to clear this with Yaniv and to drop the v10 support from the github actions.

So with your PR everything is fine,don't worry.

@BePo65, should I still do something to be able to merge this PR?

BePo65 commented 3 years ago

No, we will do the rest (but please be patient, we are quite busy at the moment).

BePo65 commented 2 years ago

The changes are part of the merged pr #65. Thank you for contributing :-)